937829 - Add multiple quick share buttons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

More is less.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 1: Add two icons

This adds 2 buttons to the quick share.
There is a visual glitch when it has to add only one icon. I tried fixing it for so many hours. It didn't work out. That would be a followup.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Fix the one icon case

This fixes it. Android got confused with "minWidth" and "width" and "weight" specifications. I told it not to worry much :P

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 3: Use history

The problem with copying is, you don't know what the original author's intent was! Sigh! History does the trick -- just like that.

I can fold all these patches together and push. With this, the quick share on the main menu is complete.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 831185 [details] [diff] [review]
Part 3: Use history

Nice cleanup

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/fx-team/rev/400927907d5a
https://hg.mozilla.org/integration/fx-team/rev/35ffb33ed329
https://hg.mozilla.org/integration/fx-team/rev/a6cfba5eb92e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/400927907d5a
https://hg.mozilla.org/mozilla-central/rev/35ffb33ed329
https://hg.mozilla.org/mozilla-central/rev/a6cfba5eb92e

Comment 7

[Aaron Train [:aaronmt]]

Testing this I realized we still have bug 880230 which is a complete nuisance.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Something got screwed up when these patches got checked in, they all touched /browser/themes/windows/Toolbar-inverted.png

Comment 9

[Ioana Chiorean]

TCs updated accordingly:
https://moztrap.mozilla.org/manage/case/10549/
https://moztrap.mozilla.org/manage/case/8225/
https://moztrap.mozilla.org/manage/case/8127/

Comment 10

[Ioana Chiorean]

(In reply to Ioana Chiorean from comment #9)
Disregard my last comment - wrong bug. :D

Comment 11

[Ioana Chiorean]

TC updated accordingly for Mobile Firefox 28 & 29 (both phone and tablet):
https://moztrap.mozilla.org/manage/case/11122/
https://moztrap.mozilla.org/manage/case/8226/

Comment 12

[Ioana Chiorean]

Was the code backed put in Fx 28 while merging into Aurora? I can't see this in the latest Aurora build Fx 28.0a2

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ioana Chiorean from comment #12)
> Was the code backed put in Fx 28 while merging into Aurora? I can't see this
> in the latest Aurora build Fx 28.0a2

Yes, in bug 946233