946233 - Revert FF28 to single quickshare behaviour

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

We'll land this in FF28 after the merge.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Revert to single quickshare behaviour (r=wesj)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8342396 [details] [diff] [review]
Revert to single quickshare behaviour (r=wesj)

This patch:
1. Moves the 'Share' menuitem back to its original position.
2. Forces UI to show only one quickshare item.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8342396 [details] [diff] [review]
Revert to single quickshare behaviour (r=wesj)

Review of attachment 8342396 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/widget/GeckoActionProvider.java
@@ -55,5 @@
>  
>          final PackageManager packageManager = mContext.getPackageManager();
>          int historySize = dataModel.getDistinctActivityCountInHistory();
> -        if (historySize > 2) {
> -            historySize = 2;

We should make this a const.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8342396 [details] [diff] [review]
Revert to single quickshare behaviour (r=wesj)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 937829 (multiple quick share)
User impact if declined: The multi-quickshare feature was not completed in time for FF28. We decided to disable it in FF28 while we work on it in FF29. 
Testing completed (on m-c, etc.): Local tests, works fine. This patch is only for FF28, not Nightly.
Risk to taking this patch (and alternatives if risky): Low, simply forces a maximum of one quick share button and moves the 'Share' menu item back to its original position.   
String or IDL/UUID changes made by this patch: n/a

Comment 5

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e13c62b4fcab

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Wesley Johnston (:wesj) from comment #3)
> Comment on attachment 8342396 [details] [diff] [review]
> Revert to single quickshare behaviour (r=wesj)
> 
> Review of attachment 8342396 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/widget/GeckoActionProvider.java
> @@ -55,5 @@
> >  
> >          final PackageManager packageManager = mContext.getPackageManager();
> >          int historySize = dataModel.getDistinctActivityCountInHistory();
> > -        if (historySize > 2) {
> > -            historySize = 2;
> 
> We should make this a const.

Done. I filed bug 957097 to do the same in m-c.