937937 - [LG] [Sound] - Volume control does not change the volume

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Ralph Daub [:rdaub]]

Hi, 

The volume controls on my LG Fireweb device does not seem to change the volume. The animation of changing the volume shows up correctly, but the actual volume under Settings > Sound > Ringer & Notifications remains unchanged.

STEPS TO REPRODUCE:
1. Go to Settings > Sound and make sure "Ringer & Notifications" is not set at 0.
2. Use the volume knobs to lower the volume all the way to mute.
2. Send a text message to the phone.

EXPECTED RESULTS:
The phone should receive a visual notification on the notification bar, but there should be no sound.


ACTUAL RESULTS:
There is a sound notification.

I am including a logcat to this bug. 

Please let me know if there is any information I could provide to help with the investigation and troubleshooting of this issue.

Thanks!!

Comment 1

[Ralph Daub [:rdaub]]

Attachment: Volume-control knob does not change the actual volume

Comment 2

[Jason Smith [:jsmith]]

Where are you changing the sound when executing step #2? Are you doing that within the settings app?

Comment 3

[Ralph Daub [:rdaub]]

Hi Jason Smith,

I tried both within the Settings app, within the Sound menu, and also on the homescreen.

Comment 4

[Omega Feng [:Omega] [:馮於懋]]

See Bug 991026 for the Sound UX spec update.

Comment 5

[Omega Feng [:Omega] [:馮於懋]]

Please see Bug 991026 for the latest UX spec.

Comment 6

[Dominic Kuo [:dkuo]]

Attachment: patch

Comment 7

[Dominic Kuo [:dkuo]]

Comment on attachment 8430668 [details] [review]
patch

Hi owners,

The sound ux spec(attachment 8420872 [details], page 6) in bug 991026 describes which volume we should control in the apps and how the sound toast should be displayed while the users pressing the volumedown/volumeup buttons. To fit the ux requirements, we have to call the AudioChannelManager api to tell gecko that, our apps want some volume to be adjustable when they are in the foreground.

And because the default audio channel type for the web apps is "normal/content", so the default volume is |Media|, for the 3rd party apps they don't to do anything then they will be associated to the |Media| volume. But our core apps should control the |Ringer & Notifications| volume, except the media apps and clock app, so the patch modified the apps with |Ringer & Notifications| volume, plus the clock app with |Alarm| volume. Note that some core apps(like Usage and Calendar) don't really produce sounds, but still we call the AudioChannelManager api to associate the volume, hope you can understand.

I simply added the AudioChannelManager api in where the apps get started, or the code block that related to the sounds thing, and everyone please let me know if I am doing right or I should put it in another place, thanks!(I am working on the integration tests in system app, will request review later)

(If anyone does not know about audio channels, please read: https://wiki.mozilla.org/WebAPI/AudioChannels)

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8430668 [details] [review]
patch

Please check my comment in github.

Comment 9

[Salvador de la Puente González [:salva]]

Comment on attachment 8430668 [details] [review]
patch

Just clarification, is 'notification' the same as |Ringer & Notifications|? If so, no problem from my part.

Comment 10

[Dominic Kuo [:dkuo]]

(In reply to Salvador de la Puente González [:salva] from comment #9)
> Comment on attachment 8430668 [details] [review]
> WIP
> 
> Just clarification, is 'notification' the same as |Ringer & Notifications|?
> If so, no problem from my part.

Yes, Ringer & Notifications share the same volume and you are correct :)

Comment 11

[Dominic Kuo [:dkuo]]

Comment on attachment 8430668 [details] [review]
patch

Arthur, I have addressed the issue on github and please take a look again, thanks!

Comment 12

[Dominic Kuo [:dkuo]]

Comment on attachment 8430668 [details] [review]
patch

Looks like James is busy on some other things, Miller, would you please take a look on the Calendar changes that I made? thanks(Please read comment 7, it should help you to understand this bug).

Comment 13

[Evan Tseng [:evanxd]]

For Calendar app, the changes look good to me.

Comment 14

[Etienne Segonzac (:etienne)]

Do we need a |navigator.mozAudioChannelManager.volumeControlChannel = 'telephony';| in the callscreen app ?

Comment 15

[Etienne Segonzac (:etienne)]

Comment on attachment 8430668 [details] [review]
patch

r+ for the dialer part

Comment 16

[Dominic Kuo [:dkuo]]

(In reply to Etienne Segonzac (:etienne) from comment #14)
> Do we need a |navigator.mozAudioChannelManager.volumeControlChannel =
> 'telephony';| in the callscreen app ?

I think probably not because ux wants the Telephony volume to be adjustable in call. Before the user answered the call, we still let the user control the Ringer & Notifications volume, after answered it, the Telephony channel should be active and so does the volume, the sound manager in system app will handle it so callscreen app does not need to call volumeControlChannel = 'telephony' to notify the mozAudioChannelManager.

(In reply to Etienne Segonzac (:etienne) from comment #15)
> Comment on attachment 8430668 [details] [review]
> WIP
> 
> r+ for the dialer part

Thanks Etienne!

Comment 17

[Dominic Kuo [:dkuo]]

Comment on attachment 8430668 [details] [review]
patch

Looks like djf is busy, Wilson, would you please read comment 7 and see if I am modifying the Camera app correctly? thanks.

Comment 18

[Wilson Page [:wilsonpage]]

Comment on attachment 8430668 [details] [review]
patch

Thanks Dominic! Just a small nit (see Github) :)

Comment 19

[Etienne Segonzac (:etienne)]

(In reply to Dominic Kuo [:dkuo] from comment #16)
> (In reply to Etienne Segonzac (:etienne) from comment #14)
> > Do we need a |navigator.mozAudioChannelManager.volumeControlChannel =
> > 'telephony';| in the callscreen app ?
> 
> I think probably not because ux wants the Telephony volume to be adjustable
> in call. Before the user answered the call, we still let the user control
> the Ringer & Notifications volume, after answered it, the Telephony channel
> should be active and so does the volume, the sound manager in system app
> will handle it so callscreen app does not need to call volumeControlChannel
> = 'telephony' to notify the mozAudioChannelManager.

Makes sense, thanks.

Comment 20

[Dominic Kuo [:dkuo]]

Comment on attachment 8430668 [details] [review]
patch

Alive,

This is the patch that I fixed base on the ux spec(Please read comment 7), and with integration tests on sound manager in system app, would you please review this? thanks.

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8430668 [details] [review]
patch

test+++++

Comment 22

[Dominic Kuo [:dkuo]]

Thanks everyone!

Landed on master: 6dac2429c49536d372d9cf5be0ac86356656ca46