Closed
Bug 938114
Opened 12 years ago
Closed 12 years ago
Build layout/base in unified mode
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
13.64 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Updated•12 years ago
|
Attachment #831490 -
Flags: review?(roc)
Comment on attachment 831490 [details] [diff] [review]
Build layout/base in unified mode
Review of attachment 831490 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/base/GraphicsBlendMode.h
@@ +10,5 @@
> +
> +#include "gfxContext.h"
> +#include "nsStyleConsts.h"
> +
> +static gfxContext::GraphicsOperator GetGFXBlendMode(uint8_t mBlendMode) {
This shouldn't be static. Just add it as a method of nsCSSRendering.
Attachment #831490 -
Flags: review?(roc) → review-
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #831490 -
Attachment is obsolete: true
Attachment #831855 -
Flags: review?(roc)
Attachment #831855 -
Flags: review?(roc) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•