Closed Bug 938134 Opened 7 years ago Closed 7 years ago

Build widget/xpwidgets in unified mode

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Assignee: nobody → ehsan
Attachment #831507 - Flags: review?(roc)
Comment on attachment 831507 [details] [diff] [review]
Build widget/xpwidgets in unified mode

Review of attachment 831507 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/ImageBridgeChild.h
@@ +359,5 @@
>     * call on the ImageBridgeChild thread.
>     */
>    virtual bool AllocUnsafeShmem(size_t aSize,
> +                                mozilla::ipc::SharedMemory::SharedMemoryType aType,
> +                                mozilla::ipc::Shmem* aShmem) MOZ_OVERRIDE;

I don't understand why this change is necessary.
Attachment #831507 - Flags: review?(roc) → review-
We both have namespace ::ipc and namespace ::mozilla::ipc.  gcc seems to be unable to reconcile the two, and when it sees code using ipc::Foo, it errors out about ipc being an ambiguous namespace.  These changes just work around that problem.

What's wrong with those changes?  I'm not sure how else I could fix this error.
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> We both have namespace ::ipc and namespace ::mozilla::ipc.  gcc seems to be
> unable to reconcile the two, and when it sees code using ipc::Foo, it errors
> out about ipc being an ambiguous namespace.  These changes just work around
> that problem.
> 
> What's wrong with those changes?  I'm not sure how else I could fix this
> error.

ni?(roc);
Flags: needinfo?(roc)
Comment on attachment 831507 [details] [diff] [review]
Build widget/xpwidgets in unified mode

Review of attachment 831507 [details] [diff] [review]:
-----------------------------------------------------------------

OK
Attachment #831507 - Flags: review- → review+
Flags: needinfo?(roc)
Blocks: unified
https://hg.mozilla.org/mozilla-central/rev/8c1363c1902f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.