938134 - Build widget/xpwidgets in unified mode

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[(no longer active)]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=6eb1ffa45750

Comment 1

[(no longer active)]

Attachment: Build widget/xpwidgets in unified mode

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 831507 [details] [diff] [review]
Build widget/xpwidgets in unified mode

Review of attachment 831507 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/ImageBridgeChild.h
@@ +359,5 @@
>     * call on the ImageBridgeChild thread.
>     */
>    virtual bool AllocUnsafeShmem(size_t aSize,
> +                                mozilla::ipc::SharedMemory::SharedMemoryType aType,
> +                                mozilla::ipc::Shmem* aShmem) MOZ_OVERRIDE;

I don't understand why this change is necessary.

Comment 3

[(no longer active)]

We both have namespace ::ipc and namespace ::mozilla::ipc.  gcc seems to be unable to reconcile the two, and when it sees code using ipc::Foo, it errors out about ipc being an ambiguous namespace.  These changes just work around that problem.

What's wrong with those changes?  I'm not sure how else I could fix this error.

Comment 4

[(no longer active)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> We both have namespace ::ipc and namespace ::mozilla::ipc.  gcc seems to be
> unable to reconcile the two, and when it sees code using ipc::Foo, it errors
> out about ipc being an ambiguous namespace.  These changes just work around
> that problem.
> 
> What's wrong with those changes?  I'm not sure how else I could fix this
> error.

ni?(roc);

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 831507 [details] [diff] [review]
Build widget/xpwidgets in unified mode

Review of attachment 831507 [details] [diff] [review]:
-----------------------------------------------------------------

OK

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c1363c1902f

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8c1363c1902f