Build widget/xpwidgets in unified mode

RESOLVED FIXED in mozilla28

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Comment 1

5 years ago
Created attachment 831507 [details] [diff] [review]
Build widget/xpwidgets in unified mode
(Assignee)

Updated

5 years ago
Assignee: nobody → ehsan
(Assignee)

Updated

5 years ago
Attachment #831507 - Flags: review?(roc)
Comment on attachment 831507 [details] [diff] [review]
Build widget/xpwidgets in unified mode

Review of attachment 831507 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/ImageBridgeChild.h
@@ +359,5 @@
>     * call on the ImageBridgeChild thread.
>     */
>    virtual bool AllocUnsafeShmem(size_t aSize,
> +                                mozilla::ipc::SharedMemory::SharedMemoryType aType,
> +                                mozilla::ipc::Shmem* aShmem) MOZ_OVERRIDE;

I don't understand why this change is necessary.
Attachment #831507 - Flags: review?(roc) → review-
(Assignee)

Comment 3

5 years ago
We both have namespace ::ipc and namespace ::mozilla::ipc.  gcc seems to be unable to reconcile the two, and when it sees code using ipc::Foo, it errors out about ipc being an ambiguous namespace.  These changes just work around that problem.

What's wrong with those changes?  I'm not sure how else I could fix this error.
(Assignee)

Comment 4

5 years ago
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> We both have namespace ::ipc and namespace ::mozilla::ipc.  gcc seems to be
> unable to reconcile the two, and when it sees code using ipc::Foo, it errors
> out about ipc being an ambiguous namespace.  These changes just work around
> that problem.
> 
> What's wrong with those changes?  I'm not sure how else I could fix this
> error.

ni?(roc);
Flags: needinfo?(roc)
Comment on attachment 831507 [details] [diff] [review]
Build widget/xpwidgets in unified mode

Review of attachment 831507 [details] [diff] [review]:
-----------------------------------------------------------------

OK
Attachment #831507 - Flags: review- → review+
(Assignee)

Updated

5 years ago
Flags: needinfo?(roc)
(Assignee)

Updated

5 years ago
Blocks: 939583
https://hg.mozilla.org/mozilla-central/rev/8c1363c1902f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.