938161 - sql_date_format() method for SQLite has an incorrect default format

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Frédéric Buclin]

editusers.cgi calls $dbh->sql_date_format('profiles_activity.profiles_when') to display changes of a user account (see action eq "activity"). When no format is passed to this method, it falls back to "%Y.%m.%d %H:%M:%s", but on SQLite, %s means "seconds since 1970-01-01", see http://www.sqlite.org/lang_datefunc.html. What we want is %S.

This means that "2013.11.13 13:53:25" is displayed as "2013.11.13 13:53:1384350805".

This could potentially cause more trouble, e.g. when passed to DateTime as the string would be unparsable or return a date object with wrong data in it.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Frédéric Buclin]

Note that SQLite support has been added in Bugzilla 4.2, see bug 337776.

Comment 3

[:glob ✱]

Comment on attachment 831535 [details] [diff] [review]
patch, v1

r=glob

Comment 4

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/DB/Sqlite.pm
Committed revision 8811.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified Bugzilla/DB/Sqlite.pm
Committed revision 8637.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified Bugzilla/DB/Sqlite.pm
Committed revision 8238.

Comment 5

[Frédéric Buclin]

Added to relnotes for 4.4.2.