938357 - Secreview: Find my Device (Client-side)

Status: RESOLVED FIXED

(mozilla.org :: Security Assurance: Review Request, task)

Description

[Paul Theriault [:pauljt] (no longer reading bugmail)]

This review is to cover the client-side code included in FirefoxOS as part of the 'Where's my fox feature' See https://wiki.mozilla.org/Services/WheresMyFox

Comment 1

[Paul Theriault [:pauljt] (no longer reading bugmail)]

I presume this is the client-side parts of where is my fox:
https://github.com/dougt/whereismyfox-app

Comment 2

[Paul Theriault [:pauljt] (no longer reading bugmail)]

Actually no, that's the original, but has been forked. Doug can you add link, cheers?

Comment 3

[Paul Theriault [:pauljt] (no longer reading bugmail)]

See also https://github.com/guilherme-pg/whereismyfox-app

Comment 4

[Guilherme Gonçalves [:ggp]]

This feature has since been moved to Gaia, and it's being developed at https://github.com/guilherme-pg/gaia/tree/findmydevice

Comment 5

[Paul Theriault [:pauljt] (no longer reading bugmail)]

thanks for the update ggp.

Comment 6

[Erin Lancaster [:elan]]

Paul, do we need to block on landing in mainline gaia on this review or can it happen post-landing? Thank you.

Comment 7

[Paul Theriault [:pauljt] (no longer reading bugmail)]

It can happen post landing (and I can't actually finish testing until it does).

BTW is this still planned for 1.4? I assumed not  with the recent change in scope and deprioritized this review but let me know this isn't correct.

Comment 8

[Frederik Braun [:freddy]]

Hey ggp,
I am starting to take a peek at the source code of findmydevice.
Whom besides you should I CC on additional bugs, that I may find during my source code review?

I will also make them block this bug for easier tracking.

Comment 9

[ggp]

I pretty much wrote all of the client code, so I'd say I'm the only person you need to CC from a technical standpoint. You may want to CC :elan on them just to make sure she's aware of the bugs we have, but I can also do that if you don't. Thanks!