Admins should be authorized to PUT a review for any user

VERIFIED FIXED in 2013-12-10

Status

Marketplace
API
P4
normal
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: basta, Assigned: mat)

Tracking

Avenir
2013-12-10
x86
Mac OS X
Points:
---

Details

(Reporter)

Description

5 years ago
When an admin PUTs an updated value for a review, it should be allowed. Instead, the API responds with a 403:

{"reason": "You do not have permission to update this review."}
(Assignee)

Comment 1

5 years ago
Trivial to do once bug 910570 is done
Priority: -- → P4
(Assignee)

Updated

5 years ago
Assignee: nobody → mpillard
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Fixed in https://github.com/mozilla/zamboni/commit/17967829cdf473eaedbc1497c2488aa44c0acc06

STR:
- Post a review on an app with a normal user
- Log out and back in with a different user that is in the 'Senior App Reviewers', 'Staff' or 'Admins' groups, try editing that review. It should work.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-12-10

Comment 3

4 years ago
Verified as fixed : http://screencast.com/t/gnBVQSqSSUK
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.