938521 - [Bluetooth] Make GetBluetoothInterface() and StringToBdAddressType() available for profile managers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

Declare the functions in header file for profile manager access.

Comment 1

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Make bt interface accessible from profile managers, r=echou

Make GetBluetoothInterface() and StringToBdAddressType() accessible from profile managers. Also fix a warning.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 832126 [details] [diff] [review]
[final] Patch 1: Make bt interface accessible from profile managers, r=echou

Review of attachment 832126 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nits addressed. Please remember to file a followup.

::: dom/bluetooth/bluedroid/gonk/BluetoothServiceBluedroid.cpp
@@ +205,5 @@
>  
> +const bt_interface_t*
> +GetBluetoothInterface()
> +{
> +  return (IsReady()) ? sBtInterface : nullptr;

"return sBtInterface" should work. Any reason to call IsReady()?

::: dom/bluetooth/bluedroid/gonk/BluetoothServiceBluedroid.h
@@ +17,5 @@
> +const bt_interface_t*
> +GetBluetoothInterface();
> +
> +void
> +StringToBdAddressType(const nsAString& aBdAddress,

This function should be placed into class like BluetoothUtil. (I've talked with Ben and he will file a followup to this)

Comment 3

[Ben Tian (inactive)]

> ::: dom/bluetooth/bluedroid/gonk/BluetoothServiceBluedroid.cpp
> @@ +205,5 @@
> >  
> > +const bt_interface_t*
> > +GetBluetoothInterface()
> > +{
> > +  return (IsReady()) ? sBtInterface : nullptr;
> 
> "return sBtInterface" should work. Any reason to call IsReady()?

IsReady() as a protection ensures sBtInterface is inaccessible when BT is disable. We should consider whether to keep the protection in follow-up bug 939020.
 
> ::: dom/bluetooth/bluedroid/gonk/BluetoothServiceBluedroid.h
> @@ +17,5 @@
> > +const bt_interface_t*
> > +GetBluetoothInterface();
> > +
> > +void
> > +StringToBdAddressType(const nsAString& aBdAddress,
> 
> This function should be placed into class like BluetoothUtil. (I've talked
> with Ben and he will file a followup to this)
Track in follow-up bug 939022.

Comment 4

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/b2g-inbound/rev/543aec80baa6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/543aec80baa6