938662 - Translation edit mode: Don't allow slug change

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: Localization, defect)

Description

[Florian Scholz (Open Web Docs)]

What did you do?
================
1. Go to https://developer.mozilla.org/de/docs/CSS$edit
2. Click on the meta data section "+ Beschreibung übersetzen"

What happened?
==============
There is a field to change the slug "Adressname in Deutsch:"


What should have happened?
==========================
No field that allows changing the slug. The only way we want to change slugs is through page moves. Otherwise things will break

Is there anything else we should know?
======================================
Was removed recently in normal edit mode, too.

Comment 1

[Jean-Yves Perrier [:teoli]]

Florian, can you double check? I think this is fixed.

Comment 2

[Florian Scholz (Open Web Docs)]

Nope, see https://developer.mozilla.org/de/docs/Web/CSS$edit where you edit using the translation view.
We really shouldn't allow slug changes other than through page move. I think things will break otherwise.
Bumping severity.

Comment 3

[Stephanie Hobson [:shobson]]

Attachment: Screen Shot 2014-07-08 at 11.40.20.png

Would it be useful to include a link to move the page? If so, what would the wording be?

Comment 4

[Jean-Yves Perrier [:teoli]]

Comment on attachment 8452512 [details]
Screen Shot 2014-07-08 at 11.40.20.png

It is exactly that. I like the (move page) (good wording).

One important point here: (move page) must appear only to logged-in users with the page move privileges.

Comment 5

[Stephanie Hobson [:shobson]]

Got the answer to my question from :teoli, don't need info from :fscholz anymore :)

Comment 6

[Stephanie Hobson [:shobson]]

Simply removing the form field breaks creation of new translations :(

Here's the code for what appears on the edit translation page (in an ideal world) but it needs the logic to not interfere with the page creation logic:

<dt>{{ _('Slug in {locale}:')|f(locale=language) }}</dt>
<dd>{{ document.slug }}
{% if user.is_authenticated() and user.has_perm('wiki.move_tree') %}
(<a href="{{ url('wiki.move', document.slug, locale=document.locale) }}">{{ _('Move this page') }}</a>)
{% endif %}
</dd>

Comment 7

[Sebastian Zartner [:sebo]]

> The only way we want to change slugs is through page moves. Otherwise things will break
And what should be done with pages where the slug was already changed?

Sebastian

Comment 8

[Kadir Topal [:atopal]]

So, apparently one thing that breaks is that by changing the slug no redirect is created, so the original URL will be 404. Not sure if there is a way to see how many documents have already been affected by this.

Comment 9

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.