938695 - Sketch, then build in code, the "Create/Edit" group page

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

In bug 936570 we started the work of specifying the create/edit group page. This is the page users will get to when they click on the "Create Group" or the "Edit Group" button. 

Here are the relevant mockups from bug 93650:

1) https://bug936570.bugzilla.mozilla.org/attachment.cgi?id=830499

2) https://bug936570.bugzilla.mozilla.org/attachment.cgi?id=831529

These mockups seem to be suggesting slightly different approaches. I think #1 will be slightly easier to implement: It has the entire create/edit operation happening on its own page (something like /group/edit/ for create, and /group/edit/group_name for edit). However, this is certainly up for discussion.

We should do a quick final sketch (a hand drawing is fine) of the group create/edit interface with all of its elements and callouts for any particular behavior not obvious; attach to this bug; ask for feedback; and when feedback is positive, build in code.

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

[The bug number above should be bug 936570.]

Comment 2

[Andrei Hajdukewycz [:sancus]]

So, it seems like the right place for the "Create Group" button is on templates/groups/index_groups.html, which is the page you get to via "browse groups" from the logged-in homepage. I also suggest that the logged-in homepage text should change to "Browse and create groups ->" from "Browse groups ->".

Comment 3

[Wray Bowling [:wbowling]]

Just confirming: in that second drawing ( https://bug936570.bugzilla.mozilla.org/attachment.cgi?id=831529 ) I intended for the "create group" button to be on the Groups List page. The dashed line indicates a split between two pages. This bug is just addressing the template below that dashed line.

Comment 4

[Wray Bowling [:wbowling]]

Attachment: 9 - create edit groups page.svg

bug 936569 Comment #1 laid out all the specs. They are visualized here.

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

This looks good to me. :williamr (or anyone else), any feedback before we jump into code?

Comment 6

[William Reynolds [:williamr]]

(In reply to Wray Bowling [:wbowling] from comment #4)
> Created attachment 8337093 [details]
> 9 - create edit groups page.svg

This mockup looks great! My only suggestion is to not include a group photo field, since groups do not currently have photos.

Comment 7

[Wray Bowling [:wbowling]]

This bug was solved in the Pull Request Dan and I worked on.
https://github.com/mozilla/mozillians/pull/748

Comment 8

[Rebecca Billings [:rbillings]]

Verified on sancus.ca able to edit group, fields include: name, desc, irc, website, wiki
not implemented: accepts new members y/n, photo

Comment 9

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on stage

QA verified on stage - /group_edit/ and /group_add/ pages match mockups and behave as expected