Closed Bug 938754 Opened 6 years ago Closed 6 years ago

Move opacity from Aero Glass Fog into alpha channel of TabsToolbar::before box-shadow colour

Categories

(Firefox :: Theme, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Keywords: perf, Whiteboard: [Australis:P2][Australis:M9])

Attachments

(1 file)

On Windows 7, we display a fog behind the tabstrip to make it easier to read the tab labels over the glass. That fog is actually a box-shadow with blur, and is semi-opaque to give it a foggy effect. Think frosted-glass.

According to mattwoodrow, putting the opacity directly on the element (the TabsToolbar::before pseudoelement to be exact), results in us taking a slow-path in layout land. It's much faster if we move the opacity value into the alpha channel of the colour we set the box-shadow.

This should result in a super-easy win for TART, according to mattwoodrow.
Attached patch Patch v1Splinter Review
Here we go. Try and compare-talos links coming up.
Comment on attachment 832526 [details] [diff] [review]
Patch v1

This is a pretty clear win.
Attachment #832526 - Flags: review?(MattN+bmo)
Comment on attachment 832526 [details] [diff] [review]
Patch v1

Review of attachment 832526 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this review. Ship it!
Attachment #832526 - Flags: review?(MattN+bmo) → review+
Landed in UX as https://hg.mozilla.org/projects/ux/rev/8b514254b168
Status: NEW → ASSIGNED
Whiteboard: [Australis:P2][Australis:M?] → [Australis:P2][Australis:M9][fixed-in-ux]
As discussed with Mike on irc, there's still somewhere else in the UI that is doing this, though it gets invalidated much less often.

I filed bug 939607 for handling this efficiently within layout.
https://hg.mozilla.org/mozilla-central/rev/8b514254b168
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][Australis:M9][fixed-in-ux] → [Australis:P2][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.