939607 - Try to avoid creating inactive layers for nsDisplayOpacity if we can

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Make PaintBoxShadowOuter take an opacity value

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Add an API for storing an opacity on a display item, and implement it for nsDisplayBoxShadowOuter

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Try fold nsDisplayOpacity items opacity value into their children

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Box shadow test

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8333591 [details] [diff] [review]
Try fold nsDisplayOpacity items opacity value into their children

Review of attachment 8333591 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsDisplayList.cpp
@@ +1089,5 @@
> +
> +      if (item->GetType() == nsDisplayItem::TYPE_OPACITY) {
> +        MOZ_ASSERT(list);
> +        nsDisplayOpacity* opacity = static_cast<nsDisplayOpacity*>(item);
> +        if (opacity->FoldOpacityOntoChildren()) {

Why don't you just make nsDisplayOpacity override ShouldFlattenAway?

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Try fold nsDisplayOpacity items opacity value into their children v2

Good point. I'm sure I had a reason for not doing this initially, but I can't remember what it was, and I can't come up with a new one.

Comment 7

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/513f5fe03a0b
https://hg.mozilla.org/integration/mozilla-inbound/rev/a64e4c44d2ef
https://hg.mozilla.org/integration/mozilla-inbound/rev/b246e0435b0f
https://hg.mozilla.org/integration/mozilla-inbound/rev/77836c897f3f

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/513f5fe03a0b
https://hg.mozilla.org/mozilla-central/rev/a64e4c44d2ef
https://hg.mozilla.org/mozilla-central/rev/b246e0435b0f
https://hg.mozilla.org/mozilla-central/rev/77836c897f3f