938931 - [B2G][FTU][UI] Checkboxes within WiFi and About Firefox OS panes overlap text

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[gbennett]

Attachment: 2013-11-14-16-10-34.png

Description:
The "Show Password" checkbox overlaps text, but the checkbox itself is still functional. The "About Firefox OS" FTU pane checkbox is center justified overlapping text as well.

Repro Steps:
1) Updated Buri 1.3 mozRIL to BuildID: 20131114143149
2) In FTU select an available WiFi network
3) Observe "Show Password" check
4) Go to "About Firefox OS" pane and observe checkbox on that pane

Actual:
Checkboxes overlaps text.

Expected:
No overlapping occurs and checkboxes appears properly.

Environmental Variables:
Device: Buri 1.3 mozRIL
BuildID: 20131114143149
Gaia: 4ea5adac92d6a9ab035e708e941d50be0d670da2
Gecko: 7b014f0f3b03
Version: 28.0a1
Firmware Version: 20131104

Notes: I was not able to get an image of the FTU WiFi Show Password checkbox as when you screenshot that pane it captures the "Select a network" pane instead for some reason (I'm going to write a bug on that tomorrow).

Repro frequency: 100%, 4/4
See attached: 2013-11-14-16-10-34.png
Related to bug: https://bugzilla.mozilla.org/show_bug.cgi?id=929565

Comment 1

[Jason Smith [:jsmith]]

That's going to be silly to ship with overlapping checkbox over text on the FTE

Comment 2

[Sarah Parsons]

This issue started to occur on the Buri 1.3 Build ID: 20131114143149

Gaia   4ea5adac92d6a9ab035e708e941d50be0d670da2
SourceStamp 7b014f0f3b03
BuildID 20131114143149
Version 28.0a1

Last working on Buri 1.3 Build ID: 20131113040200

Gaia   7243b75041c93bc7deb240131748d0b164f3f0b0
SourceStamp 7b014f0f3b03
BuildID 20131113040200
Version 28.0a1

Comment 3

[Jason Smith [:jsmith]]

yet another regression from bug 914892

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13762

Pointer to Github pull-request

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 833247 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13762

Forwarding to an FTU peer freshly back from PTO :)

Comment 9

[Fernando Campo (:fcampo)]

Comment on attachment 833247 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13762

After checking the original bug 914892 to understand the changes, it looks good to me (only tested on nighlty, though)

Comment 10

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/cf542fe79eeb9dd89968109f72442a285a02a754

Comment 11

[Jason Smith [:jsmith]]

blocking+ for layout regression