Closed Bug 938993 Opened 6 years ago Closed 6 years ago

Support Multi-SIM for Payments.

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: allstars.chh, Assigned: ferjm)

References

(Depends on 1 open bug, )

Details

Attachments

(1 file, 4 obsolete files)

Payments now will access ICC info from Bug 892068, however in multi-SIM we need to process all SIMs instead of only one.
I won't be able to work on this until late next week, so feel free to steal it from me if someone else is able to do it before.
Assignee: nobody → ferjmoreno
Is this still true? It seems like we just need to get the information from the primary SIM.
As Yoshi mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=936471#c19 this is still a valid bug and it is currently blocked by the DSDS feature. I'm removing myself as assignee until the required DSDS bits are done.
Assignee: ferjmoreno → nobody
Depends on: 936325
Blocks: 942361
cc'ing wesj. This will affect the Android implementation (when we have it).
I am not sure why this bug depends on bug 936325. Bug 936325 is talking about an advanced feature to turn on/off a 'specific' 'single' SIM card, instead of putting them both into airplane mode at the same time, while IMHO what payment needs is to get the 'standby/ready' sim cards. If my understanding is correct, the current MobilConnection and IccManager API already provide the necessary information.
You are right Hsin-Yi. The dependency was added because of the confusion between primary and active SIM in the comments from bug 936471
No longer depends on: 936325
Assignee: nobody → ferjmoreno
Depends on: 961794
Blocks: 961797
Attached patch v1 (WIP) (obsolete) — Splinter Review
Attached patch v1 (obsolete) — Splinter Review
Attachment #8362599 - Attachment is obsolete: true
Attached patch v1 (obsolete) — Splinter Review
Fabrice, you can find the rationale behind this changes in https://wiki.mozilla.org/WebAPI/WebPayment/Multi-SIM#Firefox_OS_v1.4

This patch shouldn't land until bug 961794 is fixed.
Attachment #8362995 - Attachment is obsolete: true
Attachment #8363870 - Flags: review?(fabrice)
Comment on attachment 8363870 [details] [diff] [review]
v1

Review of attachment 8363870 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/payment.js
@@ +107,5 @@
>  };
>  
>  function PaymentSettings() {
> +  try {
> +    this.numRadioInterfaces = Services.prefs.getIntPref(PREF_NUM_RADIO_INTERFACES);

Why not use nsIRadioInterfaceLayer::numRadioInterfaces ?

@@ +181,5 @@
>      try {
>        let setting = JSON.parse(aData);
> +      if (!setting.key ||
> +          setting.key !== kRilDefaultDataServiceId ||
> +          setting.key !== kRilDefaultPaymentServiceId) {

I think you want:
(!setting.key || 
 (setting.key !== kRilDefaultDataServiceId &&
  setting.key !== kRilDefaultPaymentServiceId))
Attachment #8363870 - Flags: review?(fabrice)
Attached patch v2 (obsolete) — Splinter Review
Thanks Fabrice, this patch addresses your comments.
Attachment #8363870 - Attachment is obsolete: true
Attachment #8364291 - Flags: review?(fabrice)
Attachment #8364291 - Flags: review?(fabrice)
Attached patch v2Splinter Review
Attachment #8364291 - Attachment is obsolete: true
Attachment #8364528 - Flags: review?(fabrice)
Attachment #8364528 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/1f992b7b3f3a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Depends on: 1112052
You need to log in before you can comment on or make changes to this bug.