938993 - Support Multi-SIM for Payments.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Payments now will access ICC info from Bug 892068, however in multi-SIM we need to process all SIMs instead of only one.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

I won't be able to work on this until late next week, so feel free to steal it from me if someone else is able to do it before.

Comment 2

[Andy McKay]

Is this still true? It seems like we just need to get the information from the primary SIM.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

As Yoshi mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=936471#c19 this is still a valid bug and it is currently blocked by the DSDS feature. I'm removing myself as assignee until the required DSDS bits are done.

Comment 4

[Kumar McMillan [:kumar]]

cc'ing wesj. This will affect the Android implementation (when we have it).

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I am not sure why this bug depends on bug 936325. Bug 936325 is talking about an advanced feature to turn on/off a 'specific' 'single' SIM card, instead of putting them both into airplane mode at the same time, while IMHO what payment needs is to get the 'standby/ready' sim cards. If my understanding is correct, the current MobilConnection and IccManager API already provide the necessary information.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

You are right Hsin-Yi. The dependency was added because of the confusion between primary and active SIM in the comments from bug 936471

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1 (WIP)

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Fabrice, you can find the rationale behind this changes in https://wiki.mozilla.org/WebAPI/WebPayment/Multi-SIM#Firefox_OS_v1.4

This patch shouldn't land until bug 961794 is fixed.

Comment 10

[[:fabrice] Fabrice Desré]

Comment on attachment 8363870 [details] [diff] [review]
v1

Review of attachment 8363870 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/payment.js
@@ +107,5 @@
>  };
>  
>  function PaymentSettings() {
> +  try {
> +    this.numRadioInterfaces = Services.prefs.getIntPref(PREF_NUM_RADIO_INTERFACES);

Why not use nsIRadioInterfaceLayer::numRadioInterfaces ?

@@ +181,5 @@
>      try {
>        let setting = JSON.parse(aData);
> +      if (!setting.key ||
> +          setting.key !== kRilDefaultDataServiceId ||
> +          setting.key !== kRilDefaultPaymentServiceId) {

I think you want:
(!setting.key || 
 (setting.key !== kRilDefaultDataServiceId &&
  setting.key !== kRilDefaultPaymentServiceId))

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v2

Thanks Fabrice, this patch addresses your comments.

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v2

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

Thanks Fabrice!

https://hg.mozilla.org/integration/b2g-inbound/rev/1f992b7b3f3a

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1f992b7b3f3a