938994 - Make it easier to build Fennec and Android specific tests all at once

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Nick Alexander :nalexander [he/him]]

On mobile-firefox-dev, mleibovic asked:

> As part of this process, would we change things such that you don't need 
> to build build/mobile/robocop when making changes to test files? If so, 
> that would make building test changes much more intuitive.

This was in reference to Bug 938659, which re-arranges how the Robocop test package is built.

I don't want to see mobile/android/base also build the Robocop test APK.  By rights, that would have mobile/android/base building several test APKs: JUnit 3 tests, future Espresso tests, etc.

I would prefer to see a top-level "Android App stuff" tier that quickly determined what needs to be built in order to make the Fennec APK and all test APKs.  That is, we could de-recursify all of the Java and Android build pieces in mobile/android and provide a high-level build target like the binaries tier to accomplish this.

Or, we could make mobile/android smarter and start to push developers to build mobile/android (which builds base and tests).  This is immediately tractable.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Pre: Make classes.dex depend on ANDROID_EXTRA_JARS. r=glandium

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Part 1: Move lots of files into m/a/tests/browser/robocop.

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Part 2: Move more source files.

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Part 3: Move assets.

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: Part 4: Move ini files.

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: Part 5: Move Robocop test files.

Comment 7

[Nick Alexander :nalexander [he/him]]

Attachment: Part 6: Move README.

Comment 8

[Nick Alexander :nalexander [he/him]]

Attachment: Part 7: Move roboextender.

Comment 9

[Nick Alexander :nalexander [he/him]]

Attachment: Part 8: Update build system. r=glandium

Hi glandium, the previous 7 commits will all need to be folded into
this one, since we can't move files without updating the build; I kept
the separate for my own sanity.

Can you give this a once over?  The proof, of course, is in the green
try pudding.

Comment 10

[Nick Alexander :nalexander [he/him]]

For reasons unknown, I can't retrigger that rc1 orange.  It did pass all tests before crashing with a known intermittent, though.

https://tbpl.mozilla.org/?tree=Try&rev=00fbf356d7cf

Comment 11

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 938994 - Move build/mobile/robocop into mobile/android/tests/browser/robocop. r?gbrown

Bug 938994 - Move build/mobile/robocop into mobile/android/tests/browser/robocop. r?gbrown

This builds the Robocop tests with |mach build mobile/android|, making
it easier for developers to build Fennec and the tests at the same
time.

Comment 12

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 938994 - Post: Update Gradle configurations. r=sebastian

Bug 938994 - Post: Update Gradle configurations. r?sebastian

I moved the JAR out of the root directory because I didn't want
multiple copies of things in robocop/ appearing in IntelliJ, although
this turns out to not be strictly necessary.  Keeping it as part of a
general push to move things out of the root dumping ground.

Comment 13

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ed20ca28593

Comment 14

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8685008 [details]
MozReview Request: Bug 938994 - Post: Update Gradle configurations. r=sebastian

https://reviewboard.mozilla.org/r/24695/#review22229

Comment 15

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8685007 [details]
MozReview Request: Bug 938994 - Move build/mobile/robocop into mobile/android/tests/browser/robocop. r?gbrown

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24693/diff/1-2/

Comment 16

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8685008 [details]
MozReview Request: Bug 938994 - Post: Update Gradle configurations. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24695/diff/1-2/

Comment 17

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e152435da396

Comment 18

[Geoff Brown [:gbrown]]

Comment on attachment 8685007 [details]
MozReview Request: Bug 938994 - Move build/mobile/robocop into mobile/android/tests/browser/robocop. r?gbrown

https://reviewboard.mozilla.org/r/24693/#review22253

Comment 19

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/61ff70a34b8a6eccc4bcf6eddc8b5f361d2226f0
Bug 938994 - Move build/mobile/robocop into mobile/android/tests/browser/robocop. r=gbrown

https://hg.mozilla.org/integration/fx-team/rev/1d73339d11af2e0a57416b314f0572e1f8cbac31
Bug 938994 - Post: Update Gradle configurations. r=sebastian

Comment 20

[Nick Alexander :nalexander [he/him]]

For the benefit of archaeologists: the long patch series ended up getting implemented in several pieces over many tickets, so just the dregs needed to land.  Progress!

Comment 21

[Nick Alexander :nalexander [he/him]]

dev-doc-needed and NI to me to update the Wiki.

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/61ff70a34b8a
https://hg.mozilla.org/mozilla-central/rev/1d73339d11af

Comment 23

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #21)
> dev-doc-needed and NI to me to update the Wiki.

Wiki updated, mailing list post sent: https://mail.mozilla.org/pipermail/mobile-firefox-dev/2015-November/001621.html