Closed Bug 938994 Opened 6 years ago Closed 4 years ago

Make it easier to build Fennec and Android specific tests all at once

Categories

(Firefox for Android :: Testing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

(Keywords: dev-doc-complete)

Attachments

(11 files)

1.82 KB, patch
glandium
: review+
Details | Diff | Splinter Review
61.02 KB, patch
Details | Diff | Splinter Review
2.94 KB, patch
Details | Diff | Splinter Review
269.09 KB, patch
Details | Diff | Splinter Review
613 bytes, patch
Details | Diff | Splinter Review
12.61 KB, patch
Details | Diff | Splinter Review
333 bytes, patch
Details | Diff | Splinter Review
1.18 KB, patch
Details | Diff | Splinter Review
13.16 KB, patch
glandium
: review+
Details | Diff | Splinter Review
40 bytes, text/x-review-board-request
gbrown
: review+
Details
40 bytes, text/x-review-board-request
sebastian
: review+
Details
On mobile-firefox-dev, mleibovic asked:

> As part of this process, would we change things such that you don't need 
> to build build/mobile/robocop when making changes to test files? If so, 
> that would make building test changes much more intuitive.

This was in reference to Bug 938659, which re-arranges how the Robocop test package is built.

I don't want to see mobile/android/base also build the Robocop test APK.  By rights, that would have mobile/android/base building several test APKs: JUnit 3 tests, future Espresso tests, etc.

I would prefer to see a top-level "Android App stuff" tier that quickly determined what needs to be built in order to make the Fennec APK and all test APKs.  That is, we could de-recursify all of the Java and Android build pieces in mobile/android and provide a high-level build target like the binaries tier to accomplish this.

Or, we could make mobile/android smarter and start to push developers to build mobile/android (which builds base and tests).  This is immediately tractable.
Component: General → Testing
Hi glandium, the previous 7 commits will all need to be folded into
this one, since we can't move files without updating the build; I kept
the separate for my own sanity.

Can you give this a once over?  The proof, of course, is in the green
try pudding.
Attachment #8375753 - Flags: review?(mh+mozilla)
For reasons unknown, I can't retrigger that rc1 orange.  It did pass all tests before crashing with a known intermittent, though.

https://tbpl.mozilla.org/?tree=Try&rev=00fbf356d7cf
Attachment #8375745 - Flags: review?(mh+mozilla) → review+
Attachment #8375753 - Flags: review?(mh+mozilla) → review+
Bug 938994 - Move build/mobile/robocop into mobile/android/tests/browser/robocop. r?gbrown

This builds the Robocop tests with |mach build mobile/android|, making
it easier for developers to build Fennec and the tests at the same
time.
Attachment #8685007 - Flags: review?(gbrown)
Bug 938994 - Post: Update Gradle configurations. r?sebastian

I moved the JAR out of the root directory because I didn't want
multiple copies of things in robocop/ appearing in IntelliJ, although
this turns out to not be strictly necessary.  Keeping it as part of a
general push to move things out of the root dumping ground.
Attachment #8685008 - Flags: review?(s.kaspari)
Comment on attachment 8685008 [details]
MozReview Request: Bug 938994 - Post: Update Gradle configurations. r=sebastian

https://reviewboard.mozilla.org/r/24695/#review22229
Attachment #8685008 - Flags: review?(s.kaspari) → review+
Comment on attachment 8685007 [details]
MozReview Request: Bug 938994 - Move build/mobile/robocop into mobile/android/tests/browser/robocop. r?gbrown

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24693/diff/1-2/
Comment on attachment 8685008 [details]
MozReview Request: Bug 938994 - Post: Update Gradle configurations. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24695/diff/1-2/
Attachment #8685008 - Attachment description: MozReview Request: Bug 938994 - Post: Update Gradle configurations. r?sebastian → MozReview Request: Bug 938994 - Post: Update Gradle configurations. r=sebastian
Attachment #8685007 - Flags: review?(gbrown) → review+
Comment on attachment 8685007 [details]
MozReview Request: Bug 938994 - Move build/mobile/robocop into mobile/android/tests/browser/robocop. r?gbrown

https://reviewboard.mozilla.org/r/24693/#review22253
https://hg.mozilla.org/integration/fx-team/rev/61ff70a34b8a6eccc4bcf6eddc8b5f361d2226f0
Bug 938994 - Move build/mobile/robocop into mobile/android/tests/browser/robocop. r=gbrown

https://hg.mozilla.org/integration/fx-team/rev/1d73339d11af2e0a57416b314f0572e1f8cbac31
Bug 938994 - Post: Update Gradle configurations. r=sebastian
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
For the benefit of archaeologists: the long patch series ended up getting implemented in several pieces over many tickets, so just the dregs needed to land.  Progress!
dev-doc-needed and NI to me to update the Wiki.
Flags: needinfo?(nalexander)
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/61ff70a34b8a
https://hg.mozilla.org/mozilla-central/rev/1d73339d11af
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
(In reply to Nick Alexander :nalexander from comment #21)
> dev-doc-needed and NI to me to update the Wiki.

Wiki updated, mailing list post sent: https://mail.mozilla.org/pipermail/mobile-firefox-dev/2015-November/001621.html
Flags: needinfo?(nalexander)
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.