939006 - Sort out DOM key name definition by groups in D3E draft

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 Sort out key names in Modifier Keys section

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Sort out key names in Whitespace Keys section

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.3 Sort out key names in Navigation Keys section

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.4 Sort out key names in Editing Keys section

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.5 Sort out key names in UI Keys section

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.6 Sort out key names in Device Keys section

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.7 Sort out key names in IME and Composition Keys section

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.8 Sort out key names in General-Purpose Function Keys section

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.9 Sort out key names in Multimedia Keys section

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.10 Sort out key names in Application Keys section

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.11 Sort out key names in Browser Keys section

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.12 Sort out key names in Media Controller Keys section

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.13 Sort out deprecated key names

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8428777 [details] [diff] [review]
part.1 Sort out key names in Modifier Keys section

The key value definition wasn't grouped when we implement this.

However, now, key values are grouped in each section.
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3Events-key.html

For easier to maintain the key values, we should sort out KeyNameList.h and NativeKeyToDOMKeyName.h with same order as the spec.

Additionally, now, we have string values of all keys in static variable. For reducing the footprint, let's comment out the keys which are not used on any platforms. They have "// Not used" comment in their end of lines. I'll remove this redundant comment at landing. I added it only for easier to review.

And also this patch remove the macro for OS/2. It's never used since we dropped OS/2 support.

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.5 Sort out key names in UI Keys section

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.6 Sort out key names in Device Keys section

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.12 Sort out key names in Media Controller Keys section

Comment 18

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8428791 [details] [diff] [review]
part.13 Sort out deprecated key names

Removing unused key values which are dropped from the spec.

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.7 Sort out key names in IME and Composition Keys section

Updating for today's telecon :-)

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.8 Sort out key names in General-Purpose Function Keys section

Comment 21

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8428777 [details] [diff] [review]
part.1 Sort out key names in Modifier Keys section


>+/******************************************************************************
>+ * Modifier Keys
>+ *****************************************************************************/
>+DEFINE_KEYNAME_WITH_SAME_NAME(Alt)

The spec has Accel before Alt, but Accel is ofc rather special

Comment 22

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8428788 [details] [diff] [review]
part.10 Sort out key names in Application Keys section

The Apps change doesn't seem to belong to this patch, but fine.

Comment 23

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8428984 [details] [diff] [review]
part.12 Sort out key names in Media Controller Keys section

># HG changeset patch
># User Masayuki Nakano <[e-mail]>
># Parent 60ca539096c06ff0b954613bdd79bf10910abd67
>Bug 939006 part.12 Sort out key names in Media Controller Keys section r=
>
>diff --git a/dom/events/KeyNameList.h b/dom/events/KeyNameList.h
>--- a/dom/events/KeyNameList.h
>+++ b/dom/events/KeyNameList.h
>@@ -264,21 +264,91 @@ DEFINE_KEYNAME_WITH_SAME_NAME(LaunchAppl
> DEFINE_KEYNAME_WITH_SAME_NAME(BrowserBack)
> DEFINE_KEYNAME_WITH_SAME_NAME(BrowserFavorites)
> DEFINE_KEYNAME_WITH_SAME_NAME(BrowserForward)
> DEFINE_KEYNAME_WITH_SAME_NAME(BrowserHome)
> DEFINE_KEYNAME_WITH_SAME_NAME(BrowserRefresh)
> DEFINE_KEYNAME_WITH_SAME_NAME(BrowserSearch)
> DEFINE_KEYNAME_WITH_SAME_NAME(BrowserStop)
> 
>-DEFINE_KEYNAME_WITH_SAME_NAME(Apps)
>-DEFINE_KEYNAME_WITH_SAME_NAME(List)
>+/******************************************************************************
>+ * Media Controller Keys
>+ *****************************************************************************/
>+// DEFINE_KEYNAME_WITH_SAME_NAME(AudioBalanceLeft) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(AudioBalanceRight) // Not used
>+DEFINE_KEYNAME_WITH_SAME_NAME(AudioBassBoostDown)
>+DEFINE_KEYNAME_WITH_SAME_NAME(AudioBassBoostUp)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(AudioFaderFront) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(AudioFaderRear) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(AudioSurroundModeNext) // Not used

There should be some AVRInput and AVRPower here

>+DEFINE_KEYNAME_WITH_SAME_NAME(ChannelDown)
>+DEFINE_KEYNAME_WITH_SAME_NAME(ChannelUp)
>+DEFINE_KEYNAME_WITH_SAME_NAME(Red) // Rename to ColorF0Red
>+DEFINE_KEYNAME_WITH_SAME_NAME(Green) // Rename to ColorF1Green
>+DEFINE_KEYNAME_WITH_SAME_NAME(Yellow) // Rename to ColorF2Yellow
>+DEFINE_KEYNAME_WITH_SAME_NAME(Blue) // Rename to ColorF3Blue
>+// DEFINE_KEYNAME_WITH_SAME_NAME(Grey) // Rename to ColorF4Grey // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(Brown) // Rename to ColorF5Brown // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(ClosedCaptionToggle)
>+DEFINE_KEYNAME_WITH_SAME_NAME(Dimmer)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(DisplaySwap) // Not used
>+DEFINE_KEYNAME_WITH_SAME_NAME(Exit)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(ClearFavorite0) // Rename to FavoriteClear0 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(ClearFavorite1) // Rename to FavoriteClear1 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(ClearFavorite2) // Rename to FavoriteClear2 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(ClearFavorite3) // Rename to FavoriteClear3 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(RecallFavorite0) // Rename to FavoriteRecall0 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(RecallFavorite1) // Rename to FavoriteRecall1 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(RecallFavorite2) // Rename to FavoriteRecall2 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(RecallFavorite3) // Rename to FavoriteRecall3 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(StoreFavorite0) // Rename to FavoriteStore0 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(StoreFavorite1) // Rename to FavoriteStore1 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(StoreFavorite2) // Rename to FavoriteStore2 // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(StoreFavorite3) // Rename to FavoriteStore3 // Not used
>+DEFINE_KEYNAME_WITH_SAME_NAME(Guide)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(NextDay) // Rename to GuideNextDay // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(PrevDay) // Rename to GuidePreviousDay // Not used
> DEFINE_KEYNAME_WITH_SAME_NAME(Info)
>-DEFINE_KEYNAME_WITH_SAME_NAME(Exit)
>-DEFINE_KEYNAME_WITH_SAME_NAME(Zoom)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(InstantReplay) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(Link) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(List) // Rename to ListProgram // Not used
>+DEFINE_KEYNAME_WITH_SAME_NAME(Live) // Rename to LiveContent
>+// DEFINE_KEYNAME_WITH_SAME_NAME(Lock) // Not used
>+DEFINE_KEYNAME_WITH_SAME_NAME(Apps) // Rename to MediaApps
>+DEFINE_KEYNAME_WITH_SAME_NAME(FastFwd) // Rename to MediaFastForward
>+DEFINE_KEYNAME_WITH_SAME_NAME(MediaLast)
>+DEFINE_KEYNAME_WITH_SAME_NAME(MediaPause)
>+DEFINE_KEYNAME_WITH_SAME_NAME(MediaPlay)
>+DEFINE_KEYNAME_WITH_SAME_NAME(MediaRecord)
>+DEFINE_KEYNAME_WITH_SAME_NAME(MediaRewind)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(MediaSkip)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(NextFavoriteChannel) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(NextUserProfile) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(OnDemand) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(PinPDown) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(PinPMove) // Not used
>+DEFINE_KEYNAME_WITH_SAME_NAME(PinPToggle)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(PinPUp) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(PlaySpeedDown) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(PlaySpeedReset) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(PlaySpeedUp) // Not used
>+DEFINE_KEYNAME_WITH_SAME_NAME(RandomToggle)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(RcLowBattery)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(RecordSpeedNext) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(RfBypass) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(ScanChannelsToggle) // Not used
>+// DEFINE_KEYNAME_WITH_SAME_NAME(ScreenModeNext) // Not used
>+DEFINE_KEYNAME_WITH_SAME_NAME(Settings)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(SplitScreenToggle) // Not used
STBInput and STBPower are missing here



>+DEFINE_KEYNAME_WITH_SAME_NAME(Subtitle)
>+// DEFINE_KEYNAME_WITH_SAME_NAME(Teletext) // Not used
There should be TV, TVInput and TVPower here

Comment 24

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8428791 [details] [diff] [review]
part.13 Sort out deprecated key names

>+/******************************************************************************
>+ * Deplicated
Deprecated

Comment 25

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you!

(In reply to Olli Pettay [:smaug] from comment #21)
> >+/******************************************************************************
> >+ * Modifier Keys
> >+ *****************************************************************************/
> >+DEFINE_KEYNAME_WITH_SAME_NAME(Alt)
> 
> The spec has Accel before Alt, but Accel is ofc rather special

What's the "ofc"?

(In reply to Olli Pettay [:smaug] from comment #23)
> Comment on attachment 8428984 [details] [diff] [review]
> part.12 Sort out key names in Media Controller Keys section

Thank you point them. They are added today ;-)

Comment 26

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #25)
> What's the "ofc"?
"of course" :)

Comment 27

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I see. I'll land them when m-i becomes open.

Comment 28

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed539e06f5c0
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce6205f6d94a
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c2fbf1e5cdf
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d69c4b463a9
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d7575761c43
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee87f878d131
https://hg.mozilla.org/integration/mozilla-inbound/rev/385ba5d17d16
https://hg.mozilla.org/integration/mozilla-inbound/rev/749cca6fcb05
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a5caee3463
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d8d1aa2d7e0
https://hg.mozilla.org/integration/mozilla-inbound/rev/7751a79c21bf
https://hg.mozilla.org/integration/mozilla-inbound/rev/72f432b2f079
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb6938a8c0f9

Comment 29

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] from comment #24)
> Comment on attachment 8428791 [details] [diff] [review]
> part.13 Sort out deprecated key names
> 
> >+/******************************************************************************
> >+ * Deplicated
> Deprecated

Oops, there are two mistakes... I fixed only one point. I'll fix the other point when I'll change around here.

Comment 30

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ed539e06f5c0
https://hg.mozilla.org/mozilla-central/rev/ce6205f6d94a
https://hg.mozilla.org/mozilla-central/rev/7c2fbf1e5cdf
https://hg.mozilla.org/mozilla-central/rev/4d69c4b463a9
https://hg.mozilla.org/mozilla-central/rev/6d7575761c43
https://hg.mozilla.org/mozilla-central/rev/ee87f878d131
https://hg.mozilla.org/mozilla-central/rev/385ba5d17d16
https://hg.mozilla.org/mozilla-central/rev/749cca6fcb05
https://hg.mozilla.org/mozilla-central/rev/d8a5caee3463
https://hg.mozilla.org/mozilla-central/rev/1d8d1aa2d7e0
https://hg.mozilla.org/mozilla-central/rev/7751a79c21bf
https://hg.mozilla.org/mozilla-central/rev/72f432b2f079
https://hg.mozilla.org/mozilla-central/rev/cb6938a8c0f9