Closed
Bug 939044
Opened 11 years ago
Closed 11 years ago
Get rid of MODULE
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(4 files, 2 obsolete files)
46.95 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
384.09 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
7.15 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
3.37 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
MODULE is now almost useless. Let's kill it for good.
Assignee | ||
Comment 1•11 years ago
|
||
I think this is a good enough approximation.
Attachment #832794 -
Flags: review?(gps)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #832796 -
Flags: review?(mshal)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #832798 -
Flags: review?(mshal)
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #832804 -
Flags: review?(mshal)
Assignee | ||
Updated•11 years ago
|
Attachment #832796 -
Attachment is obsolete: true
Attachment #832796 -
Flags: review?(mshal)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #832808 -
Flags: review?(gps)
Assignee | ||
Comment 6•11 years ago
|
||
There were a bit more than expected.
Attachment #832852 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Attachment #832794 -
Attachment is obsolete: true
Attachment #832794 -
Flags: review?(gps)
Updated•11 years ago
|
Attachment #832798 -
Flags: review?(mshal) → review+
Comment 7•11 years ago
|
||
Comment on attachment 832804 [details] [diff] [review] Remove most definitions of MODULE >diff --git a/dom/icc/tests/moz.build b/dom/icc/tests/moz.build >--- a/dom/icc/tests/moz.build >+++ b/dom/icc/tests/moz.build >@@ -1,8 +1,6 @@ > # -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*- > # vim: set filetype=python: > # This Source Code Form is subject to the terms of the Mozilla Public > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > >-MODULE = 'test_dom_icc' >- Does this moz.build file still need to exist? It's now empty and there's no Makefile.in
Attachment #832804 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 8•11 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #7) > Does this moz.build file still need to exist? It's now empty and there's no > Makefile.in Empty moz.build need to exist.
Updated•11 years ago
|
Attachment #832852 -
Flags: review?(gps) → review+
Updated•11 years ago
|
Attachment #832808 -
Flags: review?(gps) → review+
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5190dda14837 https://hg.mozilla.org/mozilla-central/rev/05e66d941de2 https://hg.mozilla.org/mozilla-central/rev/9266f5d70bb9 https://hg.mozilla.org/mozilla-central/rev/c029f20f7f94
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•