939052 - B2G NFC: NFC socket callback prints too much log.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

On devices without nfcd, like Unagi, emulator. ipc/nfc/Nfc.cpp will keep printing 

"OnConnectSuccess"
"OnConnectError"
"OnConnectSuccess"
"OnConnectError"
"OnConnectSuccess"
"OnConnectError"

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Just filed Bug 939056 to discuss should we enable MOZ_NFC only for some dev-device.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

As :gps said we should enable NFC only when the platform supports it, see [1],
duplicate this bug with Bug 939056

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=939056#c5

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Reopen this bug for Bug 939056 still needs to be discussed for a while, but this error message is pain for developers.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8335816 [details] [diff] [review]
Patch

Currently I enable the log message only when DEBUG flag is set.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8335816 [details] [diff] [review]
Patch

Review of attachment 8335816 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Try
https://tbpl.mozilla.org/?tree=Try&rev=8eec4b0c51fb

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b27854cba9c2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b27854cba9c2