939110 - Usage bar not showing in utility tray

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Zac C (:zac)]

1. Open utility bar, usage frame not shown


Build:
Device Hamachi
Gecko  http://hg.mozilla.org/mozilla-central/rev/b2fab608772f
Gaia  ac42cb33f21b3f13595432c965f44615daae2225
BuildID 20131115040200
Version 28.0a1

Regression range:
Since 14th Nov's nightly build

Comment 1

[Jason Smith [:jsmith]]

Very clearly caused by bug 928325

Comment 2

[Jason Smith [:jsmith]]

Gecko commit push log

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7b014f0f3b03&tochange=b2fab608772f

Comment 3

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #2)
> Gecko commit push log
> 
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=7b014f0f3b03&tochange=b2fab608772f

Skim of the gecko push log doesn't show anything obvious that caused this on the gecko side. Yeah, this definitely looks like bug 928325 caused this.

Comment 4

[Edgar Chen [:edgar]]

Hi Jason,

I found the root cause of this issue, in fact it is not caused by bug 928325.
Will provide a patch later.

Thank you.

Comment 5

[Edgar Chen [:edgar]]

Attachment: patch

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8333871 [details] [review]
patch

Hi Alive:

Could you please help to review this for me?

Thank you

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8333871 [details] [review]
patch

f+

Comment 8

[Salvador de la Puente González [:salva]]

Comment on attachment 8333871 [details] [review]
patch

Simple patch. Thank you Edgar!

Comment 9

[Edgar Chen [:edgar]]

Thanks for the review, Alive and Salvador. :)

Comment 10

[Jason Smith [:jsmith]]

(In reply to Edgar Chen [:edgar][:echen] from comment #9)
> Thanks for the review, Alive and Salvador. :)

Can you find someone to land this today in office before the next build gets spun? I'd like to get this working before our next daily smoketest tomorrow preferably.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks Edgar!

master: ffaf7085e864ed987d73cd276d0217d30f068a59

Comment 12

[Trif Andrei-Alin[:AlinT]]

QA Verified on:

Gecko  http://hg.mozilla.org/mozilla-central/rev/ba9ecdea3a90
Gaia  4ecbc106a3fcf72cbd6dd8a43c46de7bacbedf20
BuildID 20131119040204
Version 28.0a1