Closed
Bug 928325
Opened 11 years ago
Closed 11 years ago
[DSDS][Gaia] WebIccManager API will be changed for DSDS, so all relevant Apps has to be modified accordingly.
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(blocking-b2g:1.3+)
People
(Reporter: kchang, Assigned: arthurcc)
References
Details
(Whiteboard: [FT:RIL])
Attachments
(1 file)
WebIccManager API has changed for DSDS, so contacts app has to be modified accordingly.
Reporter | ||
Comment 1•11 years ago
|
||
Joe, this bug needs help from Comms App
blocking-b2g: --- → 1.3?
Flags: needinfo?(jcheng)
Comment 2•11 years ago
|
||
This bug is for backward compatibility and new API detection so that bug 814637 won't break gaia.
Comment 3•11 years ago
|
||
Not only contacts app, all application that use IccManager need to to be modified accordingly.
Component: Gaia::Contacts → Gaia
Summary: [DSDS][Gaia] WebIccManager API has changed for DSDS, so contacts app has to be modified accordingly → [DSDS][Gaia] WebIccManager API will be changed for DSDS, so all relevant Apps has to be modified accordingly.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → arthur.chen
Comment 4•11 years ago
|
||
is there a good way to know which app uses IccManager? or this information should be made available to dev-gaia? Thanks
Flags: needinfo?(jcheng) → needinfo?(echen)
Comment 5•11 years ago
|
||
We need a backward compatible API. Third party apps are using it.
Comment 6•11 years ago
|
||
We can still have a new API (keeping a backward compatible API) and convert the Gaia apps to use the new API. Some apps are just using icc_helper.js in shared/js. So, just do a wild grep and you'll have a wild guess :)
Assignee | ||
Comment 7•11 years ago
|
||
Ken, per comment 5, do we keep the original API after the new one lands? And it's time to remove IccHelper as we no longer depend on b2g18, lol.
Flags: needinfo?(kchang)
Reporter | ||
Comment 8•11 years ago
|
||
(In reply to Arthur Chen [:arthurcc] from comment #7) > Ken, per comment 5, do we keep the original API after the new one lands? I don't think so....:(. You can have more detail from bug 814637. Edgar, would you like to comment this?
Flags: needinfo?(kchang)
Comment 9•11 years ago
|
||
After grep gaia/apps, below Gaia apps use the IccHelper: * contacts * dialer * ftu * costcontrol * email * homescreen * setting * system In bug 814637, we do not plan to keep the original API. My original idea is that: It seems most of Gaia applications are using iccHelper, so we could do this backward compatible in IccHelper (detect new API or old API). After all gaia application move to new IccManager API, we can remove IccHelper. How about this flow?
Flags: needinfo?(echen)
Comment 10•11 years ago
|
||
(In reply to David Scravaglieri [:scravag] from comment #5) > We need a backward compatible API. Third party apps are using it. Hi David, could you help to provide the information of third party apps? thank you.
Flags: needinfo?(dscravaglieri)
Comment 11•11 years ago
|
||
Is it a must have item? Looks like we need to do it and just mark this one as 1.3+ for now. If you see something different, please feel free to 1.3? again.
blocking-b2g: 1.3? → 1.3+
Assignee | ||
Updated•11 years ago
|
Target Milestone: --- → 1.3 Sprint 4 - 11/8
Assignee | ||
Comment 13•11 years ago
|
||
Julien, Edgar, could you have a quick look at this patch? Thanks! The modified IccHelper is the object that has the same API on different versions of gecko (mozIccManager in the current gecko and mozIcc object after bug 814637 lands) based on the proposed changes[1]. The patch is the minimal change that we need for single sim card. The support of multiple sim cards will be introduced by other patches. [1]: https://wiki.mozilla.org/WebAPI/WebIccManager/Multi-SIM
Attachment #823222 -
Flags: feedback?(felash)
Attachment #823222 -
Flags: feedback?(echen)
Comment 14•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
looks good to me
a test is failing and some code can be written in a more compact way. And I have a naive question about the API that is used: if it does IPC, should it be asynchronous ?
Attachment #823222 -
Flags: feedback?(felash) → feedback+
Comment 16•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
Looks good to me. Thank you.
Attachment #823222 -
Flags: feedback?(echen) → feedback+
Comment 17•11 years ago
|
||
(In reply to Arthur Chen [:arthurcc] from comment #15) > Edgar, does "getIccById" do a IPC call? No, |getIccById()| and the getter of |iccIds| will not do IPC call, we maintain these information in DOM side. Thank you.
Flags: needinfo?(echen)
Assignee | ||
Comment 18•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
Hi all, could you help review the patch?
Francisco: Contacts, FTU
Etienne: Dialer
Salvador: Cost control
Christian: Homescreen
Evelyn: Settings, tz_select.js in shared
Alive: System
Julien: icc_helper.js related in shared
dave: UI test
Thanks a lot!
Attachment #823222 -
Flags: review?(salva)
Attachment #823222 -
Flags: review?(felash)
Attachment #823222 -
Flags: review?(etienne)
Attachment #823222 -
Flags: review?(ehung)
Attachment #823222 -
Flags: review?(dave.hunt)
Attachment #823222 -
Flags: review?(crdlc)
Attachment #823222 -
Flags: review?(arcturus)
Attachment #823222 -
Flags: review?(alive)
Comment 19•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
OK for me
Attachment #823222 -
Flags: review?(crdlc) → review+
Comment 20•11 years ago
|
||
Comment on attachment 823222 [details] WIP V1 looks good to me, but how can we try the patch ? with the patches in bug 814637 ?
Assignee | ||
Comment 21•11 years ago
|
||
The patch in bug 814637 is not ready yet. We will test all patches to make sure everything works well before landing.
Comment 22•11 years ago
|
||
oki, then I'll wait that bug 814637 has patches ready to give r+ :-)
Comment 23•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
r=me for the tiny tiny dialer part :)
Attachment #823222 -
Flags: review?(etienne) → review+
Comment 24•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
If this is the new way we check if IccHelper is enabled, go on.
Thank you.
Attachment #823222 -
Flags: review?(salva) → review+
Comment 25•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
The code changes for the UI tests look good to me. Zac, could you run the relevant tests against a device with a contact on the SIM card, and provide feedback? Thanks.
Attachment #823222 -
Flags: review?(dave.hunt)
Attachment #823222 -
Flags: review+
Attachment #823222 -
Flags: feedback?(zcampbell)
Comment 26•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
Do file followup to remove the redundant replacement in system.
Attachment #823222 -
Flags: review?(alive) → review+
Assignee | ||
Comment 27•11 years ago
|
||
The followup is bug 932134.
Updated•11 years ago
|
Whiteboard: [FT:RIL]
Comment 28•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
looks good. Thanks.
Attachment #823222 -
Flags: review?(ehung) → review+
Assignee | ||
Comment 29•11 years ago
|
||
Francisco, are you available for reviewing the contacts and FTU parts? Thanks! Julien, you can try the patch with the updated gecko at [1]. And you may also want check the new API[2]. [1]: http://people.mozilla.org/~echen/public/unagi_New_IccManager_API.tar.gz [2]: https://wiki.mozilla.org/WebAPI/WebIccManager/Multi-SIM
Flags: needinfo?(francisco.jordano)
Flags: needinfo?(felash)
Updated•11 years ago
|
Attachment #823222 -
Flags: review?(arcturus) → review?(francisco.jordano)
Comment 31•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
Asking Borja to review FTU
Attachment #823222 -
Flags: review?(borja.bugzilla)
Comment 32•11 years ago
|
||
Sure, I just noticed the review since it was setup to my personal email. Taking a look now :)
Flags: needinfo?(francisco.jordano)
Comment 33•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
r+ to contacts part.
Thanks a lot for the work!
Attachment #823222 -
Flags: review?(francisco.jordano) → review+
Comment 34•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
R=me for FTU part. Regarding Travis, do we need to land the other patch before merging this for making Travis green? Thanks!
Attachment #823222 -
Flags: review?(borja.bugzilla) → review+
Assignee | ||
Comment 35•11 years ago
|
||
Thanks for reviewing! I'll make sure the patch not breaking any tests before merging.
Updated•11 years ago
|
Assignee | ||
Comment 36•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
Cancel the review at first as I missed a case. We should also cache all event listeners in case the mozIcc object becomes invalid.
Attachment #823222 -
Flags: review?(felash)
Assignee | ||
Comment 37•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
Julien, I've updated the patch to address the issue of event listeners. Since with the new API design, mozIcc objects become invalid when in airplane mode, so are all registered listeners. To keep the same behaviors, IccHelper now caches all registered listeners.
Alive, Evelyn, could you help review the files related to STK again? With the new API design, the STK constants are kept in mozIccManager and not moved to mozIcc. The changes are simply looking up the constants in mozIccManager.
system: apps/system/js/icc.js
apps/system/js/icc_events.js
apps/system/js/icc_worker.js
settings: apps/settings/js/icc.js
Attachment #823222 -
Flags: review?(felash)
Attachment #823222 -
Flags: review?(ehung)
Attachment #823222 -
Flags: review?(alive)
Attachment #823222 -
Flags: review+
Comment 38•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
Works well, both with and without the gecko patch.
Please merge with a green travis.
Thanks!
Attachment #823222 -
Flags: review?(felash) → review+
Comment 39•11 years ago
|
||
Comment on attachment 823222 [details]
WIP V1
looks good to me. Thanks!
Attachment #823222 -
Flags: review?(ehung) → review+
Updated•11 years ago
|
Attachment #823222 -
Flags: review?(alive) → review+
Assignee | ||
Comment 40•11 years ago
|
||
master: d6da558d4ff61c1189a50e5f7698eea86222ad10
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 41•11 years ago
|
||
This broke a smoketest in bug 939110. John - Can you back this out?
Flags: needinfo?(jhford)
Comment 42•11 years ago
|
||
Hi Jason, I have tried back out this locally, but it doesn't fix bug 939110. I also try to find out who cause bug 939110, but have no idea yet. Thanks
Comment 43•11 years ago
|
||
(In reply to Edgar Chen [:edgar][:echen] from comment #42) > Hi Jason, > > I have tried back out this locally, but it doesn't fix bug 939110. > I also try to find out who cause bug 939110, but have no idea yet. > > Thanks Okay - saw your comment in the other bug then. Removing needinfo.
Flags: needinfo?(jhford)
Updated•11 years ago
|
Flags: needinfo?(dscravaglieri)
Updated•11 years ago
|
Attachment #823222 -
Flags: feedback?(zcampbell)
You need to log in
before you can comment on or make changes to this bug.
Description
•