Closed
Bug 939196
Opened 11 years ago
Closed 11 years ago
Allow nsThread to have nested event queues
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file)
14.93 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
This basically reverts the changes from bug 719154 but it does away with the complicated threadfilter stuff. This allows nsThread to nest event queues and generates a new nsIEventTarget for each queue.
Attachment #833026 -
Flags: review?(benjamin)
Comment 1•11 years ago
|
||
Comment on attachment 833026 [details] [diff] [review] Patch, v1 I wonder if it wouldn't be good for popEventQueue() to take the nsIEventTarget as a parameter so we can assert that we're popping things in the correct order. Also I presume these methods shouldn't be scriptable so can we add [noscript] markers? r=me with that or a really good reason why we shouldn't do it. This looks pretty good for how bad it seemed on IRC!
Attachment #833026 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/499de7433a6a
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/499de7433a6a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•