Closed Bug 939209 Opened 12 years ago Closed 12 years ago

[Action Icons - Email] Remove shadows from action icons

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: epang, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(4 files, 2 obsolete files)

remove.png
176.39 KB, image/png
Details
email.zip
84.08 KB, application/zip
Details
patch for Gaia/master
46 bytes, text/x-github-pull-request
dkuo
: review+
epang
: review+
epang
: feedback+
Details | Review
email(updated).zip
926.39 KB, application/x-zip-compressed
Details
Attached file Email-Icons.zip (obsolete) —
Hi Pavel, Please update the icons with the attached. Thanks!
Attached image remove.png —
Also, please replace the done icon with the string 'Done'. As seen here: http://buildingfirefoxos.com/building-blocks/headers.html Thanks!
Attached file email.zip (obsolete) —
Hi Pavel, Here are the email icons, I've replaced them within the folder structure gaia/apps/email... Also, the done icon will still need to be made into the string 'Done' Thanks!
Attachment #833044 - Attachment is obsolete: true
Don't start on this yet, will be updating the icons because of light tool bars. Thanks!
Attached file email.zip —
Hi Pavel, I've updated the icons to include the correct dark ones. Also, don't forget about the done button in the comment above. Thanks!
Attachment #833275 - Attachment is obsolete: true
Flags: needinfo?(pivanov)
Attached file patch for Gaia/master —
Attachment #8337426 - Flags: feedback?(epang)
Flags: needinfo?(pivanov)
Comment on attachment 8337426 [details] [review] patch for Gaia/master Looks good, but I think this should land with the toolbar update in bug 940520. If not these icons will look broken on the dark tool bar.
Attachment #8337426 - Flags: feedback?(epang) → feedback+
Marking as dependent on bug 940520 which will make the email tool bars white.
Depends on: 940520
Attachment #8337426 - Flags: review?(dkuo)
Comment on attachment 8337426 [details] [review] patch for Gaia/master Pavel, these changes looks good to me, since there are css changes with new images, but we should also commit @2x for the new images?
Attachment #8337426 - Flags: review?(dkuo) → review+
thanks for the review Dominic! We've been told that 2x graphics are no longer needed since flatfish uses a combination of 1x and 1.5 graphics.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
grrr I miss the dependency ... Revert: fb90ca3c92b1dada4d4f24dc8f3a9dd93821cc76
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file email(updated).zip —
Hi Pavel, can you update to the attached email icons? Once ready let me know. Thanks!
Flags: needinfo?(pivanov)
Attachment #8337426 - Flags: review?(epang)
Attachment #8337426 - Flags: review?(epang) → review+
Landed to master: https://github.com/pivanov/gaia/commit/71867c03b4d6f15d686c53c02d729b40b63de2a8
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Flags: needinfo?(pivanov)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: