940520 - [Building Blocks] Update Toolbar, Tab Bars and Filters

Status: RESOLVED DUPLICATE of bug 947087

(Firefox OS Graveyard :: Gaia, defect)

Description

[Eric Pang [:epang] UX]

Attachment: specs.zip

This bug is to cover the updates to the toolbars, tab bars and filters and includes the following items:

1. Update to existing dark toolbars and tab bars
2. Addition of light toolbars and tab bars
3. Update of existing light filters
4. Addition of grey filters 

Specs are attached

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Patch

Hey Eric,
this patch contains fixes for Calendar, Dialer, Music
can you test it?

Comment 5

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #4)
> Created attachment 8337603 [details]
> Patch
> 
> Hey Eric,
> this patch contains fixes for Calendar, Dialer, Music
> can you test it?

Hi Pavel, sending you feedback for this by email, thanks!

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8337603 [details]
Patch

This was a mistake sorry.

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

The patch contains fixes for the [BB] and few apps who depends on it.

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Apps Shots

Hey Eric,
hope this helps :)

Comment 9

[Eric Pang [:epang] UX]

Comment on attachment 8341237 [details]
Apps Shots

Hey Pavek,

The white tab bar looks good, I only need to check the highlight state (can you add a screen).  Can you add the email screens?


There still need to be a few adjustments for the black tool/tab bars
Selected Icon: #00caf2 (currently it's 00aacc)
highlight: #00AACC @ 100% opacity (didn't see a screen of this)
selected tab line: #00AACC @75% opacity ((currently it's 00aacc 100%)

I didn't see an example of the highlight for the black tool bar, can you attach one? (maybe from video?) 

App manager in nightly let's you take screen shots when you press highlight states.  Let me know if you want me to flash the patch to check! :)

Thanks!

Comment 10

[Eric Pang [:epang] UX]

sorry I meant Pavel :)

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: shots

Only this is true:
Selected Icon: #00caf2 (currently it's 00aacc)
because of the icons you provide me but we can change it latter

Comment 12

[Eric Pang [:epang] UX]

Comment on attachment 8340120 [details] [review]
patch for Gaia/master

thanks for all the hard work! Time for reviews :)

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey guys,

I know that this is a big patch but I hope it's easy to test everything on one place. Hope that everything is OK and we can land this safely.

Thanks in advance :)

Comment 14

[Kevin Grandon :kgrandon]

Comment on attachment 8340120 [details] [review]
patch for Gaia/master

I took a look at the calendar code and everything appears to be functioning. I did leave a few minor nits. My main concern is that we have this tabs.css, but a lot of CSS within each app it appears. It seems like this is less than ideal, but I guess works for now.

Comment 15

[Dale Harvey (:daleharvey)]

Comment on attachment 8340120 [details] [review]
patch for Gaia/master

Man this is an epic commit, but sorry the awesome screen on the browser is broken with the change, will try to take a look in the morning to see how it broke

Probably worth mentioning I couldnt enter a wifi password on FTU with this change

Comment 16

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8340120 [details] [review]
patch for Gaia/master

I think once everybody will have r+'ed you really don't need mine. 7 r+ should be sufficient :)

Comment 17

[Diego Marcos [:dmarcos]]

Submitting a patch that changes 169 files across all gaia apps is very disruptive. In my case this PR overlaps with several patches being worked in the Camera and Gallery apps. For this kind of changes I would like Visual Design to provide the specs for the UI refresh + a reference implementation. This could be either a reference app or a kitchen sink website like this one:

http://code.divshot.com/bootstrap-theme-white-plum/examples/kitchen-sink.html#navs

Visual design then could file bugs against each app to implement the new UI style following the specs+reference implementation

Comment 18

[Eric Pang [:epang] UX]

Attachment: Specs.zip

Comment 19

[Eric Pang [:epang] UX]

(In reply to Diego Marcos from comment #17)
> Submitting a patch that changes 169 files across all gaia apps is very
> disruptive. In my case this PR overlaps with several patches being worked in
> the Camera and Gallery apps. For this kind of changes I would like Visual
> Design to provide the specs for the UI refresh + a reference implementation.
> This could be either a reference app or a kitchen sink website like this one:
> 
> http://code.divshot.com/bootstrap-theme-white-plum/examples/kitchen-sink.
> html#navs
> 
> Visual design then could file bugs against each app to implement the new UI
> style following the specs+reference implementation

Hi Diego, I've attached the latest spec Peter created for the redesigned for the light and tab tool/tab bar.

Camera
I'm aware of the new visual designs Peter has created (and you are implementing).  If it will make it into 1.3 we're good to remove any update from this patch to camera.  

Gallery
I believe you are referring to the gallery edit image screen.  Same goes here, if the changes you are working on will land in 1.3 we can remove them from this patch (only the gallery edit image screen, all other screens in the gallery app with use the updated dark tool bar redesign).

Please let me know, if you don't think the updated UI visuals you are working on for Camera and gallery will land in 1.3.  In this case we should implement what this patch is asking for, but I can provide specific specs for them as I realize the ones Peter create and general over all tool/tab bars.

Regarding the format the patch was created in - talking with Pavel, I believe he created the patch in the way that makes most sense to him which checking the building block and various apps.

Comment 20

[Eric Pang [:epang] UX]

Marking as duplicate since the patch has been broken into several smaller patches.

Comment 21

[Anthony Ricaud (:rik)]

Comment on attachment 8340120 [details] [review]
patch for Gaia/master

Clearing review flags since this is a closed bug.