939211 - Omx Video fails on thumbnail generation on JB

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Diego Wilson [:diego]]

I get a an error message that points to the thumbnail in logcat [1].

I verified OMX video with a youtube video, so it seems OmxDecoder can play back video fine.

Also, manifest.ogv and meetthecubs.webm work fine. The problem seems to be only with thumbnail generation of OmxDecoder formats.

[1] E/GeckoConsole( 1143): Content JS ERROR at app://video.gaiamobile.org/js/metadata.js:344 in captureFrame: Exception in captureFrame: [Exception... "Component is not available"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: app://video.gaiamobile.org/js/metadata.js :: captureFrame :: line 338"  data: no] 
E/GeckoConsole( 1143): Content JS WARN at app://video.gaiamobile.org/js/metadata.js:242 in fail: Seek failed while creating thumbnail for /sdcard/Movies/VID_0001.3gp . Ignoring corrupt file.

Comment 1

[Diego Wilson [:diego]]

Attachment: logcat.txt

Comment 2

[Jason Smith [:jsmith]]

Can you give exact STR you used to reproduce this bug?

Comment 3

[Diego Wilson [:diego]]

STR:

1. Load this media clip to the sd card: http://download.blender.org/peach/bigbuckbunny_movies/BigBuckBunny_320x180.mp4
2. Open video app

The app fails to list the clip on my device. I'd appreciate if someone could try it out on Nexus 4 and verify that it's using the OMX decoder.

Comment 4

[Diego Wilson [:diego]]

Forgot to mention an important detail: this happens on JellyBean only.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Diego Wilson [:diego] from comment #4)
> Forgot to mention an important detail: this happens on JellyBean only.

Oh - in that case, this is unlikely a regression then.

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Diego Wilson [:diego] from comment #3)
> STR:
> 
> 1. Load this media clip to the sd card:
> http://download.blender.org/peach/bigbuckbunny_movies/BigBuckBunny_320x180.
> mp4
> 2. Open video app
> 

I confirmed the thumbnail generation on nexus-4.

Comment 7

[Sotaro Ikeda [:sotaro]]

Your hardware might failed to convert color format to RGB565 at GrallocImage::GetAsSurface(). nexus-4's hw decoder uses HAL_PIXEL_FORMAT_YCbCr_420_SP_TILED and it's support is added by Bug 911518.

Comment 8

[Sotaro Ikeda [:sotaro]]

One possibility of the problem is Diego's phone uses a proprietary color format that is not added to b2g.

Comment 9

[bhavana bajaj [:bajaj]]

(In reply to Sotaro Ikeda [:sotaro] from comment #8)
> One possibility of the problem is Diego's phone uses a proprietary color
> format that is not added to b2g.

:sotaro, can this be marked as a POVB then ? or there something we need to fix on our side for the JB support ?

Comment 10

[Sotaro Ikeda [:sotaro]]

Yes, it could be marked as POVB. On nexus-4, the thumbnails are generated.

Comment 11

[Michael Vines [:m1] [:evilmachines]]

Not so fast :)
This may still require a Gecko patch to handle yet another YcBcR format.

Comment 12

[bhavana bajaj [:bajaj]]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #11)
> Not so fast :)
:D
> This may still require a Gecko patch to handle yet another YcBcR format.
ah, I see. :sotaro, is this something you can help with ?

Comment 13

[Michael Vines [:m1] [:evilmachines]]

Diego is prolly in a better position to at least let us know what format we are missing

Comment 14

[Sotaro Ikeda [:sotaro]]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #13)
> Diego is prolly in a better position to at least let us know what format we
> are missing

Yeah, A patch/info from diego is necessary. It might need to add a proprietary color format.

Comment 15

[Inder]

:sotaro -- this is the format support we are missing: 
HAL_PIXEL_FORMAT_YCbCr_420_SP_VENUS     = 0x7FA30C04

I am getting "Invalid color conversion" for this format from here:
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/GrallocImages.cpp#267

Comment 16

[Sotaro Ikeda [:sotaro]]

(In reply to Inder from comment #15)
> :sotaro -- this is the format support we are missing: 
> HAL_PIXEL_FORMAT_YCbCr_420_SP_VENUS     = 0x7FA30C04
> 

HAL_PIXEL_FORMAT_YCbCr_420_SP_VENUS is already added to gecko by Bug 871364. If it is not added to gecko, it fails in the following line.
  http://mxr.mozilla.org/mozilla-central/source/gfx/layers/GrallocImages.cpp#227

> I am getting "Invalid color conversion" for this format from here:
> http://mxr.mozilla.org/mozilla-central/source/gfx/layers/GrallocImages.
> cpp#267

This says, android::ColorConverter in diego's hardware does not support the color conversion. It is out of gecko. It is CAF/android area. For nexus-4, we added the HAL_PIXEL_FORMAT_YCbCr_420_SP_TILED's color conversion by forking AOSP platform_frameworks_av in Bug 911548.

https://github.com/mozilla-b2g/platform_frameworks_av/blob/b2g-4.3_r2.1/media/libstagefright/colorconversion/ColorConverter.cpp

So, HAL_PIXEL_FORMAT_YCbCr_420_SP_VENUS needs to be added to android::ColorConverter you are using. I assume you are using CAF code. If it is the case, you need to add the support to CAF's android::ColorConverter.

Comment 17

[Diego Wilson [:diego]]

Fix will land in CAF

Comment 18

[Diego Wilson [:diego]]

Fix landed in CAF

https://www.codeaurora.org/cgit/quic/la/platform/frameworks/av/commit/?h=b2g_jb_3.2&id=040ca3ba634d4f294c0c3c2f3f531017df18650f