939324 - Purge before building

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Steve Fink [:sfink] [:s:]]

Running out of disk space. Looks like I'm supposed to purge before running.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Purge before building

Copied from b2g_build.py. Untested, but it seems sane. :-)

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 833218 [details] [diff] [review]
Purge before building

Hm, I think this needs better documentation, and/or command line options that give us acceptable defaults.

I think for PurgeMixin.clobber() to work for you, you need:

is_automation
clobberer_url
purge_minsize

defined in self.config, afaict at a glance.
http://hg.mozilla.org/build/mozharness/file/9dfa6c67a71e/configs/b2g/releng-beta.py#l71

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Purge before building

Ok, updated the patch to purge by default, overrideable via PROPERTIES_FILE. Not requesting review yet; I'm sending it to my slave.

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Purge before building

Ok, here's what I have that seems to work. It pulls in the needed config setting from buildbot_config, but hardcodes defaults that work so I don't have to make the buildbot changes yet.

I'm still thinking that |if self.config.get('is_automation')| could just be |if self.buildbot_config|, and then all of the needed configuration could get pulled from buildbot_config instead of going through self.config. But this'll do for now.

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 833314 [details] [diff] [review]
Purge before building

I'm not a big fan of the self.config munging.
I'm currently thinking PurgeMixin should become part of BuildbotMixin, and base a lot of things on the buildbot_config as you suggested.  (BuildbotMixin isn't specifically buildbot-as-a-project integration, as much as buildbot-as-a-MoCo-service integration.)

However, it seems like this is causing issues, so I'm going to r+ as-is.

Comment 6

[Steve Fink [:sfink] [:s:]]

I can't get through to hg.mozilla.org at the moment to land this.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Steve Fink [:sfink] from comment #6)
> I can't get through to hg.mozilla.org at the moment to land this.

The maintenance downtime is over, try again?

Comment 8

[Aki Sasaki (not active)]

Comment on attachment 833314 [details] [diff] [review]
Purge before building

https://hg.mozilla.org/build/mozharness/rev/1c4035ff2536

Comment 9

[Phil Ringnalda (:philor)]

In an alternate bugzilla db, aki said he checked it in, https://hg.mozilla.org/build/mozharness/rev/1c4035ff2536, and transplanted it to production, and since the first one I retriggered freed up 16.8GB, this smells fixed to me.

Comment 10

[Justin Wood (:Callek)]

something[s] here made it to production