Closed Bug 939441 Opened 7 years ago Closed 7 years ago

B2G Bluetooth: add test cases for navigator.BluetoothManager.enabled

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.3 C1/1.4 S1(20dec)

People

(Reporter: vicamo, Assigned: vicamo)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch (obsolete) — Splinter Review
@echou: Somehow I find Bluetooth emulation is broken again but this test case still runs.  I'll find some time to fix it.

@jgriffin, this is the first WeBluetooth Marionette test case, anything else I should have noticed?

Will push to tryserver when it's back from maintenance.
Assignee: nobody → vyang
Attachment #833358 - Flags: review?(echou)
Attachment #833358 - Flags: feedback?(jgriffin)
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #1)
> Will push to tryserver when it's back from maintenance.

Confirmed it was executed and passed.
Blocks: 939637
Attached patch patch : v2Splinter Review
s/startTestCommon/startBluetoothTestBase/.  Most Bluetooth tests can't live without a valid adapter and this make the test script here a special case.  Will add another |function startBluetoothTest| that serves all others.  See bug 939637.
Attachment #833358 - Attachment is obsolete: true
Attachment #833358 - Flags: review?(echou)
Attachment #833358 - Flags: feedback?(jgriffin)
Attachment #8333637 - Flags: review?(echou)
Attachment #8333637 - Flags: feedback?(jgriffin)
Comment on attachment 8333637 [details] [diff] [review]
patch : v2

Review of attachment 8333637 [details] [diff] [review]:
-----------------------------------------------------------------

Everything looks good to me.
Attachment #8333637 - Flags: feedback?(jgriffin) → feedback+
Comment on attachment 8333637 [details] [diff] [review]
patch : v2

Review of attachment 8333637 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks.
Attachment #8333637 - Flags: review?(echou) → review+
https://hg.mozilla.org/mozilla-central/rev/cc5b56a25d87
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in before you can comment on or make changes to this bug.