939441 - B2G Bluetooth: add test cases for navigator.BluetoothManager.enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

@echou: Somehow I find Bluetooth emulation is broken again but this test case still runs.  I'll find some time to fix it.

@jgriffin, this is the first WeBluetooth Marionette test case, anything else I should have noticed?

Will push to tryserver when it's back from maintenance.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

https://tbpl.mozilla.org/?tree=Try&rev=086af6170cf3

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #1)
> Will push to tryserver when it's back from maintenance.

Confirmed it was executed and passed.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch : v2

s/startTestCommon/startBluetoothTestBase/.  Most Bluetooth tests can't live without a valid adapter and this make the test script here a special case.  Will add another |function startBluetoothTest| that serves all others.  See bug 939637.

Comment 5

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8333637 [details] [diff] [review]
patch : v2

Review of attachment 8333637 [details] [diff] [review]:
-----------------------------------------------------------------

Everything looks good to me.

Comment 6

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8333637 [details] [diff] [review]
patch : v2

Review of attachment 8333637 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks.

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/cc5b56a25d87

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cc5b56a25d87