939637 - B2G Bluetooth: add test cases for navigator.BluetoothManager.onadapteradded

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=0dab94f942c0

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8333638 [details] [diff] [review]
patch

Review of attachment 8333638 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/tests/marionette/test_dom_BluetoothManager_adapteradded.js
@@ +9,5 @@
> +
> +startBluetoothTest(function testCaseMain(aAdapter) {
> +  log("Checking adapter attributes ...");
> +  is(aAdapter.name, "Full Android on Emulator", "adapter.name");
> +  is(aAdapter.class, 0, "adapter.class");

Racing condition for |adapter.class|.  It seems this attribute is edited as 5767692 soon after onadapteradded event is emitted.  Most of the time we got 0, but it should be 5767692 at the end.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

$ adb shell hciconfig /dev/ttyS2 class
hci0:	Type: BR/EDR  Bus: UART
	BD Address: 56:34:12:00:54:52  ACL MTU: 512:1  SCO MTU: 0:0
	Class: 0x58020c
	Service Classes: Capturing, Object Transfer, Telephony
	Device Class: Phone, Smart phone

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #2)
> ::: dom/bluetooth/tests/marionette/test_dom_BluetoothManager_adapteradded.js
> > +  is(aAdapter.class, 0, "adapter.class");
> 
> Racing condition for |adapter.class|.  It seems this attribute is edited as
> 5767692 soon after onadapteradded event is emitted.  Most of the time we got
> 0, but it should be 5767692 at the end.

See bug 932914 comment 22, 23.  Sometimes PropertyChange events come after onadapteradded.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch : v2

1) add a 3 seconds time delay before returning |aAdapter|.
2) refactor |startBluetoothTest| a little bit more so that it still works with either value of 'bluetooth.enabled'.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

See also bug 912930, "stop using adapteradded event".

Comment 7

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8333760 [details] [diff] [review]
patch : v2

Review of attachment 8333760 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fc6d66e72c59

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fc6d66e72c59