939450 - B2G NFC: nfcd does not handle handover protocol correctly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[arno]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.48 Safari/537.36

Steps to reproduce:

- Approach Android device to FFOS device
- When FFOS device gets a P2P TechDiscovered, send a Handover Request message


Actual results:

- The Android device receives the Handover Request (it enables BT and shows the Beam Download notification)
- Android will reply with a Handover Select via the LLCP channel. This Handover Select is not received by FFOS


Expected results:

The Handover Select message should have been sent to NFC Manager via another P2P TechDiscovered Notification

Comment 1

[Dimi Lee [:dimi]]

Hi Arno,
  Could you help provide the patch for sending handover request after receiving p2p TechDiscovered ?
  It will help a lot for me to check this issue, thanks !

Comment 2

[arno]

Attachment: send-hardcoded-hr.patch

At our fork of gaia, checkout branch svic/handover and apply the attached patch. Bring a FFOS and an Android device close to each other (both devices should be on their homescreen). The Android device will receive a harcoded Hr record and start the download process. However, the Hs is not received by FFOS. I would expect the debug message in nfc_manager.js:343 to show up in logcat.

Comment 3

[Dimi Lee [:dimi]]

Attachment: playform_system_nfcd_pull_request

The root cause is handover select is returned by client socket. So after sending handover request, nfcd should try receiving data from client socket.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8334389 [details] [review]
playform_system_nfcd_pull_request

merged,
https://github.com/mozilla-b2g/platform_system_nfcd/commit/8197b919e31883bf3e393e21f813b3d0db92ff8e

Comment 5

[Jason Smith [:jsmith]]

NFC isn't a committed feature, so clearing nom.