Open Bug 939566 Opened 7 years ago Updated 7 years ago

Take care of Mac-specific issues with the window title in the about:privatebrowsing page

Categories

(SeaMonkey :: UI Design, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: rsx11m.pub, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: polish, Whiteboard: [wontfix?])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #842439 +++

(Quoting Stefan [:stefanh] from bug 842439 comment #52)
> The titles are a bit tricky when it comes to Mac - we do some stuff with
> them in tabbrowser to not show the application name. The title shown in the
> title bar is OK when just loading the about:privatebrowsing page, then the
> title is "Would you like to start Private Browsing". But loading the page in
> Private Browsing mode, the title is "Private Browsing - Private Browsing"
> which is a bit odd :-)
> 
> I think what happens here is that we always append "Private Browsing" to the
> title when in Private Browsing mode. One possible solution might be to skip
> the window title for mac in this case.

(Quoting rsx11m from bug 842439 comment #55)
> The same issue should apply to Firefox. On Windows, I see "Private Browsing
> - Mozilla Firefox (Private Browsing)" and thus the same replication of the
> PB string. Adding parenthesis in the SM string should be a different bug
> we've talked about at some point, I don't know if that was ever filed.
Attached patch Possible patch (untested) (obsolete) — Splinter Review
(Quoting Stefan [:stefanh] from bug 842439 comment #62)
> (In reply to neil@parkwaycc.co.uk from bug 842439 comment #59)
> > (In reply to Stefan from bug 842439 comment #52)
> > > One possible solution might be to skip the window title for mac in this case.
> > 
> > Note that this would mean that the tab's title would revert to
> > about:privatebrowsing and the window title would be the same as for any
> > other untitled document.
> > 
> Hmm, testing (without debugQA) loading about:blank in a private window
> displays just "Private Browsing" in the title bar (but "Untitled" in the
> tab)...

(Quoting rsx11m from bug 842439 comment #63)
> Comment on attachment 8333512 [details] [diff] [review]
> Proposed patch (v7)
> 
> >+++ b/suite/common/aboutPrivateBrowsing.xul
> >+        document.getElementById("warningBox").className = "private";
> >+        document.title = document.getElementById("privateTitle").textContent;
> 
> Uncommenting the second line here gives me "SeaMonkey Private Browsing" on
> Windows rather than "Private Browsing - SeaMonkey Private Browsing" so this
> should work for the other platforms as well.

Having rephrased the window title in private mode to be more than just "Private Browsing" this may have been resolved with attachment 8333924 [details] [diff] [review] as checked in for bug 842439 already. Nevertheless, this is an addition for not setting the window title in a private window on Mac OSX only, if you'd still prefer this over the revised string (obviously untested).
Attachment #8336087 - Flags: review?(stefanh)
> +#ifndef XP_MACOSX
>          document.title = document.getElementById("privateTitle").textContent;
> +#endif

You can avoid pre-processing this file by testing for OS X:

1. if (/Mac/.test(navigator.platform))
2. if (Application.platformIsMac)
Thanks, #2 looks like the nicest version. This works fine for me on Windows (meaning, it doesn't break anything).
Attachment #8336087 - Attachment is obsolete: true
Attachment #8336087 - Flags: review?(stefanh)
Attachment #8337067 - Flags: review?(stefanh)
Stefan, any opinion on this or are you happy with the appearance established by bug 842439 on OSX?
Comment on attachment 8337067 [details] [diff] [review]
Better solution to not set it on Mac

Sorry for the delay... I'm a little bit in-between here, but I think it might be a bit inconsistent to not keep it as-is (even though the title would look better if we took the patch), so let's keep it as-is for now.
Attachment #8337067 - Flags: review?(stefanh)
Ok, let's keep it open but this bug looks like a candidate for a won't-fix then.
Maybe someone else comes up with yet another idea.
Whiteboard: [wontfix?]
You need to log in before you can comment on or make changes to this bug.