939569 - Build layout/build in unified mode

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[(no longer active)]

Attachment: Build layout/build in unified mode

Comment 2

[(no longer active)]

blanket-r=glandium

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1082eae712e0

Comment 4

[(no longer active)]

Backed out because of Windows build bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/8b676ce79d10

https://tbpl.mozilla.org/php/getParsedLog.php?id=30660139&tree=Mozilla-Inbound

Comment 5

[(no longer active)]

nsSynthVoiceRegistry.h uses #pragma once, which causes it to be included twice, once from the objdir and once from the source dir.

Comment 6

[(no longer active)]

Attachment: Stop using #pragma once in webspeech code

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8333565 [details] [diff] [review]
Stop using #pragma once in webspeech code

Hmm, is any of the headers exported as mozilla/dom/Foo.h ?
If so, the define should have mozilla_dom_ prefix.

Check that please.

Comment 8

[(no longer active)]

OK, I'll do that before landing this.

Comment 9

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/896f22d74e73
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4bb0aebdaad

Comment 10

[[e-mail]]

(In reply to Ehsan Akhgari from comment #5)
> nsSynthVoiceRegistry.h uses #pragma once, which causes it to be included
> twice, once from the objdir and once from the source dir.

Someone's using #include "nsSynthVoiceRegistry.h" instead of #include "mozilla/dom/nsSynthVoiceRegistry.h"? (Why does it begin with ns if it lives in mozilla/dom anyway?)

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/896f22d74e73
https://hg.mozilla.org/mozilla-central/rev/b4bb0aebdaad