Closed Bug 939569 Opened 7 years ago Closed 7 years ago

Build layout/build in unified mode

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files)

No description provided.
blanket-r=glandium
Assignee: nobody → ehsan
Blocks: unified
nsSynthVoiceRegistry.h uses #pragma once, which causes it to be included twice, once from the objdir and once from the source dir.
Attachment #8333565 - Flags: review?(bugs)
Comment on attachment 8333565 [details] [diff] [review]
Stop using #pragma once in webspeech code

Hmm, is any of the headers exported as mozilla/dom/Foo.h ?
If so, the define should have mozilla_dom_ prefix.

Check that please.
Attachment #8333565 - Flags: review?(bugs) → review+
OK, I'll do that before landing this.
(In reply to Ehsan Akhgari from comment #5)
> nsSynthVoiceRegistry.h uses #pragma once, which causes it to be included
> twice, once from the objdir and once from the source dir.

Someone's using #include "nsSynthVoiceRegistry.h" instead of #include "mozilla/dom/nsSynthVoiceRegistry.h"? (Why does it begin with ns if it lives in mozilla/dom anyway?)
https://hg.mozilla.org/mozilla-central/rev/896f22d74e73
https://hg.mozilla.org/mozilla-central/rev/b4bb0aebdaad
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.