939575 - Drag and drop of message into OS file system wrongly preserves TB's internal download date line in source ("From - Sun Nov 17 15:00:00 2013" ), while saving msg.eml via other methods does not

Status: NEW

(Thunderbird :: OS Integration, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #766073 +++

(Dissected from bug 766073)

STR
1 select a msg
2a Ctrl+S to save msg as subject...eml; inspect 1st line of source
2b drag & drop to save msg as subject...eml; inspect 1st line of source

Actual result

2a Ctrl+S 1st line of source:
e.g. X-Account-Key: account10
When saving normally, we (imo correctly) remove TB's internal download date line before saving the message.eml.

2b d&d 1st line of source:
e.g. "From - Sun Nov 17 15:00:00 2013"
When saving via d&d, we (imo wrongly) preserve TB's internal download date line when saving the message.eml.

Iow, 1st line is different depending on method of saving used -> violating ux-consistency.

Expected result

Save exactly same source for 2a and 2b. Method shouldn't matter.
For 2b drag&drop-saving (as in 2a normal saving) we should remove TB's internal download date line before saving message.eml

Comment 1

[WADA:World Anti-bad-Duping Agency]

I believe "Drag&Drop of mail to desktop" is not "Save As in .eml file" currently.
Major function of "Drag&Drop of mail" == "Move or Copy mail between local mail folders".
And, "Move or Copy mail between local mail folders" requires "Copy of From - ..." line. 

> TB's internal download date line

This is not "TB's internal download date line".
This is required "mail separator" in Unix Mbox format file, and Tb merely puts "local time without TIMEZOE" in the line upon POP3 download, Drag&Drop of .eml file to mail folder(import of .eml file by Drag&Drop).  

FYI. 

When no Tb specific header or line in .eml file(same as IMAP mail), Tb adds following lines when .eml is imported to local mail folder by Drag&Drop.
> From - Tue Nov 19 19:00:55 2013
> X-Mozilla-Status: 0001
> X-Mozilla-Status2: 00000000
> X-Mozilla-Keys:
If "From - ..." line exists in .eml file, Tb escapes it.
> >From - Tue Nov 19 19:00:55 2013

Variants of "excess header line" ;
(a) Copy to .eml file to desktop by Drag&Drop. 
    this bug, Unix Mbox mail separator.
(b) "COPY" from local mail folder to IMAP folder.
    Bug 426651, X-Account-Key:, X-UIDL:, X-Mozilla-Keys:, and Unix Mbox mail separator
                if format is different from Tb's expectation.  
(c) forwarded mail(message/rfc822 part) a mail as attachment.
    Bug 270068, X-Account-Key: & X-Mozilla-Keys:

Comment 2

[WADA:World Anti-bad-Duping Agency]

Correction.
If Drag&Drop of .eml file to mail folder(import of .eml file by Drag&Drop), timestamp in "From - ..." line was "timestamp in Date: header".