Closed
Bug 939578
Opened 11 years ago
Closed 11 years ago
Build netwerk/streamconv in unified mode
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
10.98 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
I only needed to add an #include guard to ParseFTPList.h.
https://tbpl.mozilla.org/?tree=Try&rev=319370e81f11
Attachment #8333533 -
Flags: review?(mcmanus)
Assignee | ||
Comment 1•11 years ago
|
||
Comment on attachment 8333533 [details] [diff] [review]
unify-netwerk-streamconv.patch
I need to fix a build error. :\
Attachment #8333533 -
Flags: review?(mcmanus)
Assignee | ||
Comment 2•11 years ago
|
||
I needed to make the following changes:
* Move static definition NS_DEFINE_CID(kTestConverterCID) from a header file to a .cpp file.
* Consolidate duplicate saturate() function definitions.
* Remove nsBinHexDecoder.cpp's unnecessary CR and LF #defines because were conflicting with the nsCRT::CR and nsCRT:LF enums on non-OSX platforms.
Green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=4f353f28c6c8
Attachment #8333533 -
Attachment is obsolete: true
Attachment #8333726 -
Flags: review?(mcmanus)
Updated•11 years ago
|
Attachment #8333726 -
Flags: review?(mcmanus) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•11 years ago
|
||
Keywords: checkin-needed
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•