Closed Bug 939622 Opened 6 years ago Closed 6 years ago

Remove LIBXUL_LIBRARY for intermediate libs that end up in gkmedias

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

What LIBXUL_LIBRARY does is:
  - Imply FORCE_STATIC_LIB
  - Build with -DIMPL_LIBXUL
  - Build with -DMOZILLA_INTERNAL_API

The incriminated intermediate libs are:
  - moz2d
  - angle
  - cairo
  - pixman
  - graphite2
  - harfbuzz
  - ots
  - qcms
  - skia

They are all third party code (or handled like third party code for moz2d). Besides FORCE_STATIC_LIB, none of the side effects of LIBXUL_LIBRARY should be needed.
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Attachment #8333607 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/5c94c8c9989e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.