Closed Bug 939039 Opened 7 years ago Closed 7 years ago

Make FINAL_LIBRARY imply FORCE_STATIC_LIB

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files, 1 obsolete file)

All things using FINAL_LIBRARY are expected to be static libraries. So we can just imply FORCE_STATIC_LIB when FINAL_LIBRARY is set.
This also moves the LIBXUL_LIBRARY implies FORCE_STATIC_LIB test in the emitter
instead of config.mk, since both variables are defined in moz.build exclusively.
backend.mk can end up with both LIBXUL_LIBRARY and FORCE_STATIC_LIB defined, but
it's just fine.

Note this patch alone makes the build fail. It requires the patch I'm going to attach to be folded into it, but i thought it was better, for review, to separate the logic change to the mostly automated FORCE_STATIC_LIB removals that go with it.
Attachment #832786 - Flags: review?(gps)
I had forgotten about tests.
Attachment #832803 - Flags: review?(gps)
Attachment #832786 - Attachment is obsolete: true
Attachment #832786 - Flags: review?(gps)
Attachment #832803 - Flags: review?(gps) → review+
Attachment #832787 - Flags: review?(gps) → review+
Blocks: 939622
Blocks: 939632
https://hg.mozilla.org/mozilla-central/rev/a02c4f6de455
https://hg.mozilla.org/mozilla-central/rev/7fac57f507f2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.