Closed
Bug 939632
Opened 11 years ago
Closed 11 years ago
Allow LIBRARY_NAME to be omitted when FINAL_LIBRARY is defined
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(2 files, 4 obsolete files)
1.95 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
151.31 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Having to use a LIBRARY_NAME for intermediate libraries is an unfortunate implementation detail, and developers shouldn't have to do anything about it.
Thanks to FINAL_LIBRARY, it's now possible to make leaf libraries have a generated name, and stop bother developers.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8333618 -
Flags: review?(gps)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8333619 -
Flags: review?(gps)
Assignee | ||
Comment 3•11 years ago
|
||
I'm not touching the other intermediate libraries because that has an impact on linking order, which may or may not affect memory usage during linking and/or performance. This leaves things in the same order as they currently are. Eventually, we should be able to make more things set FINAL_LIBRARY to xul directly.
Assignee | ||
Updated•11 years ago
|
Attachment #8333618 -
Attachment is obsolete: true
Attachment #8333618 -
Flags: review?(gps)
Assignee | ||
Comment 5•11 years ago
|
||
Leave out libmemory, we use it.
Attachment #8333666 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Attachment #8333619 -
Attachment is obsolete: true
Attachment #8333619 -
Flags: review?(gps)
Assignee | ||
Comment 6•11 years ago
|
||
The previous typo fix was for bug 939074.
Attachment #8333747 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Attachment #8333662 -
Attachment is obsolete: true
Attachment #8333662 -
Flags: review?(gps)
Assignee | ||
Comment 7•11 years ago
|
||
Some more LIBRARY_NAMEs are still needed.
Attachment #8333797 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Attachment #8333666 -
Attachment is obsolete: true
Attachment #8333666 -
Flags: review?(gps)
Updated•11 years ago
|
Attachment #8333747 -
Flags: review?(gps) → review+
Comment 8•11 years ago
|
||
Comment on attachment 8333797 [details] [diff] [review]
Remove LIBRARY_NAME for leaf libraries
Review of attachment 8333797 [details] [diff] [review]:
-----------------------------------------------------------------
This is beautiful.
Attachment #8333797 -
Flags: review?(gps) → review+
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7222bce61677
https://hg.mozilla.org/mozilla-central/rev/e4b59fdbc9c2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•11 years ago
|
Whiteboard: [qa-]
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•