939632 - Allow LIBRARY_NAME to be omitted when FINAL_LIBRARY is defined

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Having to use a LIBRARY_NAME for intermediate libraries is an unfortunate implementation detail, and developers shouldn't have to do anything about it.

Thanks to FINAL_LIBRARY, it's now possible to make leaf libraries have a generated name, and stop bother developers.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Allow LIBRARY_NAME to be omitted when FINAL_LIBRARY is defined

Comment 2

[Mike Hommey [:glandium]]

Attachment: Remove LIBRARY_NAME for leaf libraries

Comment 3

[Mike Hommey [:glandium]]

I'm not touching the other intermediate libraries because that has an impact on linking order, which may or may not affect memory usage during linking and/or performance. This leaves things in the same order as they currently are. Eventually, we should be able to make more things set FINAL_LIBRARY to xul directly.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Allow LIBRARY_NAME to be omitted when FINAL_LIBRARY is defined

Fixed typo

Comment 5

[Mike Hommey [:glandium]]

Attachment: Remove LIBRARY_NAME for leaf libraries

Leave out libmemory, we use it.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Allow LIBRARY_NAME to be omitted when FINAL_LIBRARY is defined

The previous typo fix was for bug 939074.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Remove LIBRARY_NAME for leaf libraries

Some more LIBRARY_NAMEs are still needed.

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8333797 [details] [diff] [review]
Remove LIBRARY_NAME for leaf libraries

Review of attachment 8333797 [details] [diff] [review]:
-----------------------------------------------------------------

This is beautiful.

Comment 9

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/7222bce61677
https://hg.mozilla.org/mozilla-central/rev/e4b59fdbc9c2