Closed Bug 939632 Opened 6 years ago Closed 6 years ago

Allow LIBRARY_NAME to be omitted when FINAL_LIBRARY is defined

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files, 4 obsolete files)

Having to use a LIBRARY_NAME for intermediate libraries is an unfortunate implementation detail, and developers shouldn't have to do anything about it.

Thanks to FINAL_LIBRARY, it's now possible to make leaf libraries have a generated name, and stop bother developers.
Attachment #8333619 - Flags: review?(gps)
I'm not touching the other intermediate libraries because that has an impact on linking order, which may or may not affect memory usage during linking and/or performance. This leaves things in the same order as they currently are. Eventually, we should be able to make more things set FINAL_LIBRARY to xul directly.
Fixed typo
Attachment #8333662 - Flags: review?(gps)
Attachment #8333618 - Attachment is obsolete: true
Attachment #8333618 - Flags: review?(gps)
Leave out libmemory, we use it.
Attachment #8333666 - Flags: review?(gps)
Attachment #8333619 - Attachment is obsolete: true
Attachment #8333619 - Flags: review?(gps)
The previous typo fix was for bug 939074.
Attachment #8333747 - Flags: review?(gps)
Attachment #8333662 - Attachment is obsolete: true
Attachment #8333662 - Flags: review?(gps)
Some more LIBRARY_NAMEs are still needed.
Attachment #8333797 - Flags: review?(gps)
Attachment #8333666 - Attachment is obsolete: true
Attachment #8333666 - Flags: review?(gps)
Attachment #8333747 - Flags: review?(gps) → review+
Comment on attachment 8333797 [details] [diff] [review]
Remove LIBRARY_NAME for leaf libraries

Review of attachment 8333797 [details] [diff] [review]:
-----------------------------------------------------------------

This is beautiful.
Attachment #8333797 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/7222bce61677
https://hg.mozilla.org/mozilla-central/rev/e4b59fdbc9c2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.