Closed
Bug 939690
Opened 11 years ago
Closed 11 years ago
Blocklist tests do not reset the current blocklist which cause following add-on installations to fail with "Modal dialog has been found and processed"
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(firefox25 fixed, firefox26 fixed, firefox27 fixed, firefox28 fixed, firefox-esr17 fixed, firefox-esr24 fixed)
People
(Reporter: AndreeaMatei, Assigned: whimboo)
References
Details
(Whiteboard: [mozmill-test-failure])
Attachments
(2 files)
7.25 KB,
patch
|
davehunt
:
review+
whimboo
:
checkin+
|
Details | Diff | Splinter Review |
6.07 KB,
patch
|
AndreeaMatei
:
review+
|
Details | Diff | Splinter Review |
Started failing Friday afternoon, on different Windows versions: Win 8, 8.1, vista so far.
http://mozmill-daily.blargon7.com/#/functional/report/d7f12eb72275b30155ba68b8bcb977d7
http://mozmill-daily.blargon7.com/#/functional/report/d7f12eb72275b30155ba68b8bcb9607a
I didn't reproduced locally a few minutes after these failures.
Comment 2•11 years ago
|
||
I can reproduce it locally with Mozmill 2.0.1 and Nightly 28 (Australis) along with a few other failures.
http://mozmill-crowd.blargon7.com/#/remote/report/456bebe92845279408c15c03e81b1f91
Assignee | ||
Comment 3•11 years ago
|
||
Which platforms are affected? Is that Australis related?
Comment 4•11 years ago
|
||
This is not Australis related. It reproduces also with non-Australis build:
http://mozmill-crowd.blargon7.com/#/functional/report/456bebe92845279408c15c03e8216da3
It is not reproducible with Mozmill 2.0:
http://mozmill-crowd.blargon7.com/#/functional/report/456bebe92845279408c15c03e82a93d7
Comment 5•11 years ago
|
||
Indeed I don't see any of them with 2.0 but they are apparent in 2.0.1
I see a new Notification Panel that seems to be blocking our attempt to install an addon that reads: "Nightly prevented this site (addons.mozilla.org) from asking you to install software on your computer"
Blocks: 744007
Comment 6•11 years ago
|
||
We're also seeing them with mozmill 1.5.24:
http://mozmill-daily.blargon7.com/#/remote/report/456bebe92845279408c15c03e8602dc1
status-firefox27:
--- → affected
Comment 7•11 years ago
|
||
I'll try to figure this one out.
Assignee: nobody → andrei.eftimie
Status: NEW → ASSIGNED
Comment 8•11 years ago
|
||
I can always reproduce this failure if I run a testrun with the following tests in that order
> restartTests/testAddons_InstallAddonWithoutEULA
> testAddons/testInstallAddonWithEULA.js
This doesn't fail if I don't use mozmill-automation and run the tests in sequence.
Assignee | ||
Comment 9•11 years ago
|
||
I don't want to wait longer to get this fixed. So I will take this now.
Assignee: andrei.eftimie → hskupin
OS: Windows 8 → All
Assignee | ||
Comment 10•11 years ago
|
||
So the problem here is that the downloaded blocklist is not getting removed from the file system by both the hard and soft blocklist test. That means the blocklist is still active for the currently used profile (--profile argument).
Summary: Test failure "Modal dialog has been found and processed" across several restart tests → Blocklist tests do not reset the current blocklist which cause following add-on installations to fail with "Modal dialog has been found and processed"
Assignee | ||
Comment 11•11 years ago
|
||
We are seeing this with mozmill-automation 2.0.1 all the time because of the newly introduced workspace feature. With it the profile location keeps the same and does not vary in its name under /tmp. It might be that we can see other teardown issues as well.
Assignee | ||
Updated•11 years ago
|
Priority: -- → P1
Assignee | ||
Updated•11 years ago
|
status-firefox25:
--- → affected
status-firefox26:
--- → affected
status-firefox-esr17:
--- → affected
status-firefox-esr24:
--- → affected
Assignee | ||
Comment 12•11 years ago
|
||
This fixes all of the installation failures of add-ons because of a still active blocklist. Please review whoever comes first. :)
Attachment #8338422 -
Flags: review?(dave.hunt)
Attachment #8338422 -
Flags: review?(andrei.eftimie)
Attachment #8338422 -
Flags: review?(andreea.matei)
Updated•11 years ago
|
Attachment #8338422 -
Attachment is patch: true
Comment 13•11 years ago
|
||
Comment on attachment 8338422 [details] [diff] [review]
Patch v1
Review of attachment 8338422 [details] [diff] [review]:
-----------------------------------------------------------------
Nice work! Just one issue with an unused import of utils but otherwise r+ from me, although I haven't run the tests myself.
::: firefox/tests/functional/restartTests/testAddons_installUninstallHardBlocklistedExtension/test2.js
@@ +6,5 @@
>
> // Include required modules
> var addons = require("../../../../lib/addons");
> var { assert } = require("../../../../../lib/assertions");
> +var utils = require("../../../../lib/utils");
We're importing this but not using it in this file.
Attachment #8338422 -
Flags: review?(dave.hunt)
Attachment #8338422 -
Flags: review?(andrei.eftimie)
Attachment #8338422 -
Flags: review?(andreea.matei)
Attachment #8338422 -
Flags: review+
Assignee | ||
Comment 14•11 years ago
|
||
Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/4b92a728d9a5
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Updated•11 years ago
|
status-firefox29:
fixed → ---
Assignee | ||
Comment 15•11 years ago
|
||
http://hg.mozilla.org/qa/mozmill-tests/rev/c36645e8467d (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/26b8934ae6db (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/09fb4ff1412b (release)
I have to wait with the backport for esr branches until the refactoring backport on bug 927397 has been landed on those branches first.
Assignee | ||
Comment 16•11 years ago
|
||
Landed on esr24:
http://hg.mozilla.org/qa/mozmill-tests/rev/41600321b428
I will come up with a patch for esr17 in a bit.
Assignee | ||
Updated•11 years ago
|
Attachment #8338422 -
Flags: checkin+
Assignee | ||
Comment 17•11 years ago
|
||
That's the backport patch for esr17 with updated paths.
Attachment #8339235 -
Flags: review?(andrei.eftimie)
Attachment #8339235 -
Flags: review?(andreea.matei)
Reporter | ||
Comment 18•11 years ago
|
||
Comment on attachment 8339235 [details] [diff] [review]
backport esr17 v1
Review of attachment 8339235 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good Henrik!
Attachment #8339235 -
Flags: review?(andrei.eftimie)
Attachment #8339235 -
Flags: review?(andreea.matei)
Attachment #8339235 -
Flags: review+
Assignee | ||
Comment 19•11 years ago
|
||
Landed on esr17:
http://hg.mozilla.org/qa/mozmill-tests/rev/f3a5bc461f85
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•