Closed Bug 939690 Opened 11 years ago Closed 11 years ago

Blocklist tests do not reset the current blocklist which cause following add-on installations to fail with "Modal dialog has been found and processed"

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

defect

Tracking

(firefox25 fixed, firefox26 fixed, firefox27 fixed, firefox28 fixed, firefox-esr17 fixed, firefox-esr24 fixed)

RESOLVED FIXED
Tracking Status
firefox25 --- fixed
firefox26 --- fixed
firefox27 --- fixed
firefox28 --- fixed
firefox-esr17 --- fixed
firefox-esr24 --- fixed

People

(Reporter: AndreeaMatei, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(2 files)

Started failing Friday afternoon, on different Windows versions: Win 8, 8.1, vista so far.

http://mozmill-daily.blargon7.com/#/functional/report/d7f12eb72275b30155ba68b8bcb977d7

http://mozmill-daily.blargon7.com/#/functional/report/d7f12eb72275b30155ba68b8bcb9607a 

I didn't reproduced locally a few minutes after these failures.
I can reproduce it locally with Mozmill 2.0.1 and Nightly 28 (Australis) along with a few other failures.
http://mozmill-crowd.blargon7.com/#/remote/report/456bebe92845279408c15c03e81b1f91
Which platforms are affected? Is that Australis related?
Indeed I don't see any of them with 2.0 but they are apparent in 2.0.1

I see a new Notification Panel that seems to be blocking our attempt to install an addon that reads: "Nightly prevented this site (addons.mozilla.org) from asking you to install software on your computer"
Blocks: 744007
I'll try to figure this one out.
Assignee: nobody → andrei.eftimie
Status: NEW → ASSIGNED
I can always reproduce this failure if I run a testrun with the following tests in that order
> restartTests/testAddons_InstallAddonWithoutEULA
> testAddons/testInstallAddonWithEULA.js

This doesn't fail if I don't use mozmill-automation and run the tests in sequence.
I don't want to wait longer to get this fixed. So I will take this now.
Assignee: andrei.eftimie → hskupin
OS: Windows 8 → All
So the problem here is that the downloaded blocklist is not getting removed from the file system by both the hard and soft blocklist test. That means the blocklist is still active for the currently used profile (--profile argument).
Summary: Test failure "Modal dialog has been found and processed" across several restart tests → Blocklist tests do not reset the current blocklist which cause following add-on installations to fail with "Modal dialog has been found and processed"
We are seeing this with mozmill-automation 2.0.1 all the time because of the newly introduced workspace feature. With it the profile location keeps the same and does not vary in its name under /tmp. It might be that we can see other teardown issues as well.
Priority: -- → P1
Attached patch Patch v1Splinter Review
This fixes all of the installation failures of add-ons because of a still active blocklist. Please review whoever comes first. :)
Attachment #8338422 - Flags: review?(dave.hunt)
Attachment #8338422 - Flags: review?(andrei.eftimie)
Attachment #8338422 - Flags: review?(andreea.matei)
Attachment #8338422 - Attachment is patch: true
Comment on attachment 8338422 [details] [diff] [review]
Patch v1

Review of attachment 8338422 [details] [diff] [review]:
-----------------------------------------------------------------

Nice work! Just one issue with an unused import of utils but otherwise r+ from me, although I haven't run the tests myself.

::: firefox/tests/functional/restartTests/testAddons_installUninstallHardBlocklistedExtension/test2.js
@@ +6,5 @@
>  
>  // Include required modules
>  var addons = require("../../../../lib/addons");
>  var { assert } = require("../../../../../lib/assertions");
> +var utils = require("../../../../lib/utils");

We're importing this but not using it in this file.
Attachment #8338422 - Flags: review?(dave.hunt)
Attachment #8338422 - Flags: review?(andrei.eftimie)
Attachment #8338422 - Flags: review?(andreea.matei)
Attachment #8338422 - Flags: review+
Depends on: 943311
Landed on esr24:
http://hg.mozilla.org/qa/mozmill-tests/rev/41600321b428

I will come up with a patch for esr17 in a bit.
Attachment #8338422 - Flags: checkin+
That's the backport patch for esr17 with updated paths.
Attachment #8339235 - Flags: review?(andrei.eftimie)
Attachment #8339235 - Flags: review?(andreea.matei)
Comment on attachment 8339235 [details] [diff] [review]
backport esr17 v1

Review of attachment 8339235 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good Henrik!
Attachment #8339235 - Flags: review?(andrei.eftimie)
Attachment #8339235 - Flags: review?(andreea.matei)
Attachment #8339235 - Flags: review+
Landed on esr17:
http://hg.mozilla.org/qa/mozmill-tests/rev/f3a5bc461f85
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
No longer depends on: 943311
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: