939717 - do not normalise email addresses for gravatar

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Florian Bender]

So my Gravatar is enabled in the prefs (and added to gravatar.com), but it never showed. The hash is different from what gravatar.com says, though that is probably due to privacy extensions!?

FTR, here's the "correct" URL: http://www.gravatar.com/avatar/89db5ccbe71d2e916c218c85076fbd96.png

Additional info in case it's helpful: 
– I changed my BMO Email address a couple of times, though not since the sandstone theme switch. 
– My BMO account is a "legacy" account which I now login to with Persona.
– The Gravatar is not the default on gravatar.com.

Let me know if I can do something to fix this on my side.

Comment 1

[:glob ✱]

we currently normalise email addresses by removing everything after and including the +
so the email we're hashing for gravatar is action [e-mail]

i don't recall why i made that decision, and i can't think of any good reason to always use the email adress verbatim.

Comment 2

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/Gravatar/Extension.pm
Committed revision 9149.

Comment 3

[Florian Bender]

Thanks!