Closed
Bug 939890
Opened 11 years ago
Closed 10 years ago
Don't build iLBC/G722/iSAC audio codecs for webrtc
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
Tracking | Status | |
---|---|---|
b2g-v1.3T | --- | fixed |
People
(Reporter: jesup, Assigned: glandium)
References
Details
Attachments
(1 file, 3 obsolete files)
9.80 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
While we don't use the optional audio codecs in WebRTC in Mozilla, we build the code for them even if they're not configured on in webrtc_config.gypi. This isn't a huge problem and avoids inadvertent regressions, except that a) if the linker doesn't remove them for no references, we might waste a little space, b) it takes a (small) amount of time to compile them, but most importantly c) if I make a debug build for B2G on Linux, the compiler fails with an internal compiler error building the iSAC neon optimizations. So, better to fully remove them if they're not configured on.
Reporter | ||
Comment 2•10 years ago
|
||
Reporter | ||
Comment 3•10 years ago
|
||
Reporter | ||
Updated•10 years ago
|
Attachment #8346814 -
Attachment is obsolete: true
Assignee | ||
Comment 4•10 years ago
|
||
This is based on your patch, with audio_coding_sources figured.
Attachment #8346937 -
Flags: review?(rjesup)
Assignee | ||
Updated•10 years ago
|
Assignee: rjesup → mh+mozilla
Status: NEW → ASSIGNED
Reporter | ||
Comment 5•10 years ago
|
||
works with <@(sources) now. However, turning on iLBC or other codecs will fail in link due to lack of including libiLBC.a.desc for example. That can be dealt with later in a different bug, though, as that issue already existed.
Reporter | ||
Updated•10 years ago
|
Attachment #8346836 -
Attachment is obsolete: true
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8346937 [details] [diff] [review] Don't build iLBC/G722/iSAC audio codecs for webrtc Review of attachment 8346937 [details] [diff] [review]: ----------------------------------------------------------------- your solution was better.... Note that I think actually enabling other codecs causes link errors, but I think that was already the case. ::: media/webrtc/trunk/webrtc/modules/audio_coding/main/source/audio_coding_module.gypi @@ +77,5 @@ > 'acm_generic_codec.cc', > 'acm_generic_codec.h', > 'acm_neteq.cc', > 'acm_neteq.h', > # cheat until I get audio_coding_sources to work remove comment
Attachment #8346937 -
Flags: review?(rjesup) → review+
Reporter | ||
Updated•10 years ago
|
Attachment #8347379 -
Attachment is obsolete: true
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Randell Jesup [:jesup] from comment #5) > Created attachment 8347379 [details] [diff] [review] > Disable compiling unused codecs > > works with <@(sources) now. However, turning on iLBC or other codecs will > fail in link due to lack of including libiLBC.a.desc for example. That can > be dealt with later in a different bug, though, as that issue already > existed. Bug 949334 will take care of this :) (but as of now it breaks windows builds :( )
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0044fa6c7fda
Assignee | ||
Comment 9•10 years ago
|
||
Forgot to update the comment. https://hg.mozilla.org/integration/mozilla-inbound/rev/616533049b4c
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0044fa6c7fda https://hg.mozilla.org/mozilla-central/rev/616533049b4c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Comment 11•10 years ago
|
||
Bug 970864 needs this patch to fix the compiling error when enable B2G_NOOPT.
blocking-b2g: --- → 1.3?
Comment 12•10 years ago
|
||
(In reply to StevenLee[:slee] from comment #11) > Bug 970864 needs this patch to fix the compiling error when enable B2G_NOOPT. I think you meant to nominate this for tarako, as the bug referenced here is 1.3T?
blocking-b2g: 1.3? → 1.3T?
Comment 14•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/b4a9ccb290a9
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•