939890 - Don't build iLBC/G722/iSAC audio codecs for webrtc

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

While we don't use the optional audio codecs in WebRTC in Mozilla, we build the code for them even if they're not configured on in webrtc_config.gypi.

This isn't a huge problem and avoids inadvertent regressions, except that a) if the linker doesn't remove them for no references, we might waste a little space, b) it takes a (small) amount of time to compile them, but most importantly c) if I make a debug build for B2G on Linux, the compiler fails with an internal compiler error building the iSAC neon optimizations.

So, better to fully remove them if they're not configured on.

Comment 1

[Mike Hommey [:glandium]]

This is now blocking bug 949334.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP patch to disable compiling unused codecs (old version)

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP patch to disable compiling unused codecs (new version)

Comment 4

[Mike Hommey [:glandium]]

Attachment: Don't build iLBC/G722/iSAC audio codecs for webrtc

This is based on your patch, with audio_coding_sources figured.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Disable compiling unused codecs

works with <@(sources) now.  However, turning on iLBC or other codecs will fail in link due to lack of including libiLBC.a.desc for example.  That can be dealt with later in a different bug, though, as that issue already existed.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8346937 [details] [diff] [review]
Don't build iLBC/G722/iSAC audio codecs for webrtc

Review of attachment 8346937 [details] [diff] [review]:
-----------------------------------------------------------------

your solution was better....  Note that I think actually enabling other codecs causes link errors, but I think that was already the case.

::: media/webrtc/trunk/webrtc/modules/audio_coding/main/source/audio_coding_module.gypi
@@ +77,5 @@
>          'acm_generic_codec.cc',
>          'acm_generic_codec.h',
>          'acm_neteq.cc',
>          'acm_neteq.h',
>  # cheat until I get audio_coding_sources to work

remove comment

Comment 7

[Mike Hommey [:glandium]]

(In reply to Randell Jesup [:jesup] from comment #5)
> Created attachment 8347379 [details] [diff] [review]
> Disable compiling unused codecs
> 
> works with <@(sources) now.  However, turning on iLBC or other codecs will
> fail in link due to lack of including libiLBC.a.desc for example.  That can
> be dealt with later in a different bug, though, as that issue already
> existed.

Bug 949334 will take care of this :) (but as of now it breaks windows builds :( )

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0044fa6c7fda

Comment 9

[Mike Hommey [:glandium]]

Forgot to update the comment.
https://hg.mozilla.org/integration/mozilla-inbound/rev/616533049b4c

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0044fa6c7fda
https://hg.mozilla.org/mozilla-central/rev/616533049b4c

Comment 11

[StevenLee[:slee]]

Bug 970864 needs this patch to fix the compiling error when enable B2G_NOOPT.

Comment 12

[Jason Smith [:jsmith]]

(In reply to StevenLee[:slee] from comment #11)
> Bug 970864 needs this patch to fix the compiling error when enable B2G_NOOPT.

I think you meant to nominate this for tarako, as the bug referenced here is 1.3T?

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ for tarako

Comment 14

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/b4a9ccb290a9