Closed Bug 93992 Opened 25 years ago Closed 22 years ago

Checkbox-nbsp-text causes table row to extend too far

Categories

(Core :: Layout: Tables, defect, P1)

defect

Tracking

()

RESOLVED WORKSFORME
Future

People

(Reporter: gregvalure, Unassigned)

References

Details

(Keywords: testcase)

Attachments

(3 files)

Build ID: 2001080110 Reproducable: Always If you look at the attached file, one cell causes its row to extend past the edge of the table instead of properly stretching its column. This only occurs (that I know of) when the cell contains a checkbox-nbsp-word without spaces sequence.
Keywords: testcase
Attached file Testcase #2 —
Confirmed, 2001-08-09-04 on Windows 98 SE.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Analysis: The problem here is that the cell content reports a maxElementSize corresponding to the form element instead of the whole line. It correctly reports the desired size for the form element + &nbsp; + nonbreakable text. When it places all boxes the layout is not able to create a line break inside '&nbsp;aaaaaaa' and filles instead the desired size, while the LayoutStrategy based on the min content width assumed that the cell will break the line. The line break occures when one removes the &nbsp; I think the critical place is http://lxr.mozilla.org/seamonkey/source/layout/html/base/src/nsLineLayout.cpp#1836 Where we skip the &nbsp;aaaaa width because it is smaller then the form element width. I would prefer some more sophisticated logic here, whether the corresponding frame is able to perform a linebreak or not. Reassigning the bug to Chris Waterson as this is LineLayout. Chris, this is in my opinion one of the incarnations of the <img><img> linebreak bugs, and fixing this would kill a large number of potentail dupes.
Assignee: karnaze → waterson
Nice work, bernd -- it does sound an awful lot like bug 32191. attinasi, are you working on this now under the auspices of bug 54565? (If so, feel free to take the bug from me...)
Assignee: waterson → attinasi
Depends on: 32191
Priority: -- → P2
Target Milestone: --- → mozilla0.9.4
Taking - this will be fixed when we get out max-element-width story straight for lines made up of multiple frames (see bug 32191 and bug 54565, which is a special case of the problem).
The fix for bug 32191 (and bug 54565) does not fix this. There is more to do, obviously. For example, we need to figure out if we want form controls to contine text runs like images do.
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.4 → mozilla0.9.5
end of milestone shuffle...
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Moving out to Mozilla 1.01 due to no URL being impacted (and limited engineering resources to work on it).
Target Milestone: mozilla0.9.6 → mozilla1.0.1
Moving Mozilla 1.01 bugs to 'future' milestone with priority P1 I will be pulling bugs from 'future' milestones when scheduling later work.
Priority: P2 → P1
Target Milestone: mozilla1.0.1 → Future
*** Bug 138055 has been marked as a duplicate of this bug. ***
Is bug 148148 related to this?
*** Bug 148148 has been marked as a duplicate of this bug. ***
It sure is. As noted in bug 148148, setting nowrap in td eliminates the problem.
Setting platform and OS to all since bug 148148 was reported on Linux.
OS: Windows 98 → All
Hardware: PC → All
attinasi will probably not work on those bugs :-(
Assignee: attinasi → table
Status: ASSIGNED → NEW
QA Contact: amar → madhur
Target Milestone: Future → ---
Target Milestone: --- → Future
Greg, none of the testcase overlap now, is this wfm? winxp2004090507
Looks like WFM even on 1.7 (20040616/XP)
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: