Closed
Bug 939950
Opened 12 years ago
Closed 12 years ago
Build gfx/moz2d in unified mode
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 3 obsolete files)
|
11.68 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8334026 -
Flags: review?(ehsan)
Attachment #8334026 -
Flags: review?(bjacob)
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → bgirard
Attachment #8334026 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8334026 -
Flags: review?(ehsan)
Attachment #8334026 -
Flags: review?(bjacob)
Attachment #8334030 -
Flags: review?(ehsan)
Attachment #8334030 -
Flags: review?(bjacob)
|
|
Assignee | |
Comment 2•12 years ago
|
||
before:
real 0m2.884s
user 0m15.290s
sys 0m1.499s
after:
real 0m3.257s
user 0m5.206s
sys 0m0.478s
Saves 10 cpu seconds.
|
||
Updated•12 years ago
|
Attachment #8334030 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8334030 [details] [diff] [review]
patch v1.1
Review of attachment 8334030 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/DrawTargetCG.h
@@ +3,5 @@
> * License, v. 2.0. If a copy of the MPL was not distributed with this
> * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>
> +#ifndef _MOZILLA_GFX_DRAWTARGET_CG_H_
> +#define _MOZILLA_GFX_DRAWTARGET_CG_H_
Please use:
mozilla_gfx_DrawTargetCG_h
to conform to our coding styles.
Attachment #8334030 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
r=Bas for moz2d fix up. GetObject is defined by some windows header. See http://stackoverflow.com/questions/3223854/getobject-getobjecta-linker-error .
Attachment #8334030 -
Attachment is obsolete: true
Attachment #8334075 -
Flags: review?(bas)
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
|
Assignee | |
Comment 7•12 years ago
|
||
Attachment #8334075 -
Attachment is obsolete: true
Attachment #8334075 -
Flags: review?(bas)
Attachment #8334080 -
Flags: review?
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8334080 -
Flags: review? → review?(bas)
|
||
Comment 8•12 years ago
|
||
Comment on attachment 8334080 [details] [diff] [review]
patch v1.3
Review of attachment 8334080 [details] [diff] [review]:
-----------------------------------------------------------------
Ugh, of course. Can you push this to Moz2D as well? Or let me know when you push it so I can do that.
Attachment #8334080 -
Flags: review?(bas) → review+
|
|
Assignee | |
Comment 9•12 years ago
|
||
Sure, I'll push it
|
|
Assignee | |
Comment 10•12 years ago
|
||
|
|
Assignee | |
Comment 11•12 years ago
|
||
|
||
Comment 12•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•