939991 - Lithuanian keyboard layout for Gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

Assuming I'll find the time to localize B2G into Lithuanian, I would love to see a proper Lithuanian keyboard layout by that time as well.

Comment 1

[Rimas Kudelis [use needinfo to ping]]

Attachment: Github pull request

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

Hi Rimas, thanks for the patch! The basic layout is qwerty which seems OK according to Google. I'm a bit worried about the number of 'alt' characters that are available in the main layout. Don't you ever need f.e. áàâäåãāæ ? I'd say to keep those but have ą as the first alt character under a...

Also do you know any Lithuanian who can do a peer-review of the keyboard? Petras Slekys?

Comment 3

[Rimas Kudelis [use needinfo to ping]]

The accented characters you mentioned have two use-cases in Lithuanian texts:
1) in foreign words (e.g. proper names).
2) `, ~, and ´ accents are used as stress marks.

Regarding use-case 2: considering rareness of stress marks being used in everyday texts and discomfort of typing them with a touch-screen keyboard, my gut says that nobody would use them anyway. Furthermore, some of the characters with stress marks don't even have separate Unicode codepoints and have to be composed from a base character and a combining diacritic. I doubt anyone would try to send that in an SMS or using facebook. :)

Use-case 1 is obvious. I guess to type foreign words, people can add the en-US keyboard which contains lots of characters with diacritics, but sadly not Lithuanian (cf bug #939986).

So to summarise, we may or may not add these symbols, but they aren't really needed often. 

By the way, I actually wanted to add another row above QWERTY and put letters ąčęėįšųūž there, but such layout would not compile. I wish we could implement that...

Comment 4

[Rimas Kudelis [use needinfo to ping]]

What are we waiting for?

Regarding the peer review, yes, you can ask Petras if you want.

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

Hi Rimas, sorry, I don't see issues when there's no activity, so I didn't notice nothing happened here in the past weeks.

Petras, can you give quick feedback on this patch?

Comment 6

[Petras Slekys]

Hello,

I agree with Rimas. Lithuanian keyboard doesn't really need the accented characters you have mentioned. We only use them as stress marks ( ` , ´ , ˜ ). Moreover, we don't use these at all: âäåãāæ. It will only disturb while writing a text message.

If you have any more questions, don't hesitate to ask.

Petras

Comment 7

[Rimas Kudelis [use needinfo to ping]]

Jan, can we please proceed?

Comment 8

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8348205 [details] [review]
Github pull request

Yep, thanks for pinging me. I'll review tomorrow.

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: PR against latest master

r=janjongboom

Comment 10

[Jan Jongboom [:janjongboom] (inactive)]

Landed in https://github.com/mozilla-b2g/gaia/commit/f69e055fe5aab034925ce7f961da7306fb1ceb99

Thanks Rimas for taking the time to do this.

Comment 11

[Rimas Kudelis [use needinfo to ping]]

Thank you!