940052 - Customize tab gets truncated

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Ian Bicking (:ianbicking)]

Attachment: customize truncation

This is in Australis:

When I have an overflowing number of tabs, and I go into Customize and Control, and I select Customize, a new tab is opened.  This tab is truncated in the tab bar (as shown in the attached screenshot).

Comment 1

[:Gijs (he/him)]

Jared, should this not have been fixed by your work on the tabstrip, or do we need something else, like an ensureVisible(tab) after entering customize mode? In which case, maybe more up Mike's alley?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

ensureVisible is called when the tab is switched to. However after the tab is created, we then do the transitions to increase the window padding as customization mode is being entered. When I reproduce this, I can see the full tab when it is switched to, and then the tab container gets narrower as the window paddings are increased.

As a band-aid fix, we could call ensureVisible(tab) again after customization mode has been entered.

Comment 4

[Justin Dolske [:Dolske]]

Hmm. This doesn't seem to reproduce for me. I always get a full tab.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

I was able to reproduce this on my Windows 7 box with Nightly.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8350462 [details] [diff] [review]
Patch

Review of attachment 8350462 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. Thanks jaws!

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/668bf950acc1

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/668bf950acc1