Fix JS_STACK_GROWTH_DIRECTION > 0

RESOLVED FIXED in mozilla31

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Jeroen Roovers, Assigned: Aaro Koskinen)

Tracking

25 Branch
mozilla31
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [bugday-20131125])

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8334144 [details] [diff] [review]
firefox-25.0-stack-grows-up.patch

User Agent: Mozilla/5.0 (X11; Linux parisc64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131118203615

Steps to reproduce:

On HPPA (PA RISC) and probably IA64 (Itanium), the stack grows up, not down. The JS code supports this, but recent changes (since version 20) broke that support.


Actual results:

Compile failure.


Expected results:

With the attached patch, Firefox should compile nicely on platforms where the stack grows up, not down. Writing this in Firefox on just such a platform (Gentoo Linux/HPPA).
(Reporter)

Comment 1

4 years ago
Created attachment 8334171 [details] [diff] [review]
7006_fixup_hppa_support.patch

Another JS_STACK_GROWTH_DIRECTION patch Gentoo has been carrying for a while.

Updated

4 years ago
Component: Untriaged → JavaScript Engine
Product: Firefox → Core
Whiteboard: [bugday-20131125]
Comment on attachment 8334171 [details] [diff] [review]
7006_fixup_hppa_support.patch

Bill, hg says you're the last one who modified that line :)
Attachment #8334171 - Flags: review?(wmccloskey)
Comment on attachment 8334144 [details] [diff] [review]
firefox-25.0-stack-grows-up.patch

Luke, hg says you're the last one who modified that line :)
Attachment #8334144 - Flags: review?(luke)

Updated

4 years ago
Attachment #8334144 - Flags: review?(luke) → review+
Attachment #8334171 - Flags: review?(wmccloskey) → review+

Comment 4

4 years ago
Should be noted that Attachment #8334171 [details] [diff]  has landed on m-c , unsure when.

Comment 5

4 years ago
as i said these are already landed; no point leaving this open.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → aaro.koskinen
Depends on: 958940
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.