940061 - Fix JS_STACK_GROWTH_DIRECTION > 0

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeroen Roovers]

Attachment: firefox-25.0-stack-grows-up.patch

User Agent: Mozilla/5.0 (X11; Linux parisc64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131118203615

Steps to reproduce:

On HPPA (PA RISC) and probably IA64 (Itanium), the stack grows up, not down. The JS code supports this, but recent changes (since version 20) broke that support.


Actual results:

Compile failure.


Expected results:

With the attached patch, Firefox should compile nicely on platforms where the stack grows up, not down. Writing this in Firefox on just such a platform (Gentoo Linux/HPPA).

Comment 1

[Jeroen Roovers]

Attachment: 7006_fixup_hppa_support.patch

Another JS_STACK_GROWTH_DIRECTION patch Gentoo has been carrying for a while.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8334171 [details] [diff] [review]
7006_fixup_hppa_support.patch

Bill, hg says you're the last one who modified that line :)

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8334144 [details] [diff] [review]
firefox-25.0-stack-grows-up.patch

Luke, hg says you're the last one who modified that line :)

Comment 4

[Ian Stakenvicius]

Should be noted that Attachment #8334171 [details] [diff]  has landed on m-c , unsure when.

Comment 5

[Ian Stakenvicius]

as i said these are already landed; no point leaving this open.