958940 - SpiderMonkey (mozjs-24.2.0) build failure on Linux/PA-RISC

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Aaro Koskinen]

User Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20131215 Firefox/24.0 Iceweasel/24.2.0 (Nightly/Aurora)
Build ID: 20131215160340

Steps to reproduce:

mozjs-24.2.0 compilation on Linux/PA-RISC with GCC 4.8.2 and GLIBC 2.18.


Actual results:

Two files fail to build:

/work/parisc/mozjs-24.2.0/js/src/gc/RootMarking.cpp: In function 'void MarkConservativeStackRoots(JSTracer*, bool)':
/work/parisc/mozjs-24.2.0/js/src/gc/RootMarking.cpp:323:14: error: invalid conversion from 'uintptr_t {aka unsigned int}' to 'uintptr_t* {aka unsigned int*}' [-fpermissive]
     stackMin = rt->nativeStackBase;
              ^
make[4]: *** [RootMarking.o] Error 1

/work/parisc/mozjs-24.2.0/js/src/jsapi.cpp: In constructor 'JSRuntime::JSRuntime(JSUseHelperThreads)':
/work/parisc/mozjs-24.2.0/js/src/jsapi.cpp:868:5: error: 'nativeStackLimit' was not declared in this scope
     nativeStackLimit = UINTPTR_MAX;
     ^
make[4]: *** [jsapi.o] Error 1



Expected results:

Build should be successful.

Comment 1

[Aaro Koskinen]

Attachment: 0001-mozjs-parisc-workaround.patch

Workaround patch #1.

Comment 2

[Aaro Koskinen]

Attachment: 0002-mozjs-parisc-workaround.patch

Workaround patch #2.

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 8358933 [details] [diff] [review]
0001-mozjs-parisc-workaround.patch

nbp: You were reviewing the MIPS JIT patches. Are you an appropriate reviewer for these patches to fix the PA-RISC build?

Comment 4

[Nicolas B. Pierron [:nbp]]

Thanks for these contributions :)

I guess you are not enabling any JIT yet, because they are not thought at all with the idea of stack growing upward.

Terrence might have more ideas if there is any expectation from the GC point of view.  I would not expect that non-conservative GC would be dependent on the stack order, but I do not know.

Are you maintaining Firefox for a Linux distribution which works on PA-RISC?

Comment 5

[Chris Peterson [:cpeterson]]

I landed the two patches as one commit:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb0b6f2f3ca9

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Accidental backout and reland:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b85b16dc226
https://hg.mozilla.org/integration/mozilla-inbound/rev/e43020f1f491

Comment 7

[Terrence Cole [:terrence]]

Code for conservative scanning of an upward growing stack has existed since I've been hacking on the GC. As far as I know it is /totally untested/ and I am *highly sceptical* that it will work at all. The only reason I didn't rip it out years ago was so that it could serve as a placeholder for whoever has to rewrite it.

Please test thoroughly. In particular you would be well served using the JS_GC_ZEAL environment variable. Use |JS_GC_ZEAL=help ./path/to/js| to get a list of options.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e43020f1f491