940099 - Australis: SDK based add-ons (and possibly others?) return to the navbar after being removed in customize mode

Status: RESOLVED DUPLICATE of bug 854226

(Firefox :: Toolbars and Customization, defect)

Description

[Austin King [:ozten]]

Nightly 28.0a1 (2013-11-18) on Mac 10.7.5.

My main profile had a bunch of Addons which used the toolbar, so now in Australis, it looks like this
http://dl.dropbox.com/u/10060532/Screenshots/Ixhd.png

I used the customize feature to remove them all. Once I restart, they come back.

Steps to Reproduce
1) Install some addons
2) Restart and note Addon icons next to the Hamburger
3) Click Hamburger > Customize
4) Drag Addon Icons into white pane of the left
5) Click Customize to end customization
6) Restart nightly

Expected:
I should have a nice clean toolbar

Actual:
Nightly forgets these customizations and I'm back to a crufty toolbar next to the hamburger

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

I know at least the Add-on Compat add-on (I assume that's the green puzzle-piece icon) is forcibly re-adding itself to the add-on bar shim (which dumps it into the nav-bar). Perhaps the others are doing that too.

I'm surprised to see Lightbeam doing that. ZER0, is this forcing-of-toolbarbuttons something that the SDK widget API allows?

Comment 2

[Sören Hentzschel]

I have the same problem with MemChaser, Lightbeam and my self developed add-ons Current Pushlog, Copy Extensions to Clipboard and SubToMe (all three are SDK based add-ons and uses the widget API).

Comment 3

[:Gijs (he/him)]

Matteo, do you have any idea what's up here?

Comment 5

[Albert Scheiner [:alberts]]

Duplicates? 935471 927257

Comment 8

[Nils Maier [:nmaier]]

The SDK doesn't allow to "remove" toolbar buttons created using the "widget" module (the default and only supported way to create toolbar buttons).

The way to fix this is to fix the SDK.

SDK always inserts:
https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/widget.js#L610-L618