Closed Bug 940178 Opened 10 years ago Closed 10 years ago

Build cairo in unified mode

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: ehsan.akhgari, Assigned: BenWa)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

unify cairo
1.85 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
Benoit, are you interested in taking this?
FWIW I tried to unify cairo. It's easy but it doesn't really provide a win because it's c compilication and cairo doesn't include much stuff.
Do you have numbers?  I would actually expect this to be much bigger win on C code since the ratio of the actual compilation time is probably lower relative to the (near constant/linear) overhead...
No I don't. But it was easy to get working.
(In reply to comment #3)
> No I don't. But it was easy to get working.

In that case, it would be nice if you can resurrect the patch!  :-)
Attached patch unify cairo — — Splinter Review 
Assignee: nobody → bgirard
Status: NEW → ASSIGNED

        Attachment #8334541 -
        Flags: review?(ehsan)

    
    

    
  
before:
real	0m2.146s
user	0m9.979s
sys	0m1.397s
after:
real	0m1.633s
user	0m6.482s
sys	0m0.473s

    
  

        Attachment #8334541 -
        Flags: review?(ehsan) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/970ef8123dc3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

    
  
Whiteboard: [qa-]

          You need to log in
          before you can comment on or make changes to this bug.