940218 - Build memory/jemalloc and friends in unified mode

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: unify-jemalloc.patch

Green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=774abfd2bb55

Comment 1

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3d41ab0a2df

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3d41ab0a2df

Comment 3

[(no longer active)]

Backed out for causing bug 941616: https://hg.mozilla.org/integration/mozilla-inbound/rev/f7e67f388134

Comment 4

[Catalin Iacob]

Attachment: Minimal patch that works on Windows with --enable-dmd

The initial patch changed:
memory/build/moz.build
memory/jemalloc/moz.build
memory/mozalloc/moz.build

https://bugzilla.mozilla.org/show_bug.cgi?id=941616#c5 decided that memory/build/ shouldn't be built in unified mode

The memory/jemalloc/moz.build part gives the linking errors in https://bugzilla.mozilla.org/show_bug.cgi?id=941616#c8 (at least on Windows, when building with --enable-dmd)

At least some of the linking errors happen because each .c file defines a JEMALLOC_<SMTH>_C_ macro in the beginning and those macros change what various includes generate.

For example tcache.c defines JEMALLOC_TCACHE_C_ which decides whether tcache.h generates tcache_tsd_boot via the malloc_tsd_funcs macro:

 #if (defined(JEMALLOC_ENABLE_INLINE) || defined(JEMALLOC_TCACHE_C_))
 /* Map of thread-specific caches. */
 malloc_tsd_externs(tcache, tcache_t *)
 malloc_tsd_funcs(JEMALLOC_INLINE, tcache, tcache_t *, NULL,
     tcache_thread_cleanup)

When we build in unified mode some other file pulls in tcache.h before JEMALLOC_TCACHE_C_ gets defined so no malloc_tsd_funcs is generated.

Given that every jemalloc .c file starts with such a macro which could change arbitrary things it's safer to just not build any of it in unified mode.

We are therefore left with only memory/mozalloc/moz.build which this patch proposes.

Comment 5

[(no longer active)]

Comment on attachment 8337681 [details] [diff] [review]
Minimal patch that works on Windows with --enable-dmd

Review of attachment 8337681 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a9035c95322

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7a9035c95322