Closed Bug 940235 Opened 7 years ago Closed 7 years ago

Build uriloader in unified mode

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 2 obsolete files)

R?_940235_unify-uriloader-v3.patch
11.77 KB, patch
ehsan
: review+
Details | Diff | Splinter Review
Attached patch unify-uriloader.patch (obsolete) — — Splinter Review 
No description provided.
Comment on attachment 8334395 [details] [diff] [review]
unify-uriloader.patch

oops: patch had link errors related to inconsistent PR_LOGGING definitions.
Attachment #8334395 - Attachment is obsolete: true
Unassigning myself because I don't have time to investigate these link errors right now.
Assignee: cpeterson → nobody
Status: ASSIGNED → NEW
Bug 941854 uncovers a bunch of forced NSPR logging here, see:

$ git grep FORCE uriloader/
uriloader/base/nsURILoader.h:21:// #define FORCE_PR_LOG
uriloader/exthandler/nsExternalHelperAppService.cpp:8:#define FORCE_PR_LOG
uriloader/exthandler/nsExternalHelperAppService.h:10:#define FORCE_PR_LOG
uriloader/prefetch/nsOfflineCacheUpdate.cpp:7:#define FORCE_PR_LOG
uriloader/prefetch/nsOfflineCacheUpdateService.cpp:7:#define FORCE_PR_LOG

You should exclude these files from the unified build; that will fix the link issue.  Are you planning on updating your patch?
Flags: needinfo?(cpeterson)
Attached patch unify-uriloader-v2.patch (obsolete) — — Splinter Review 
Let's try this again:
https://tbpl.mozilla.org/?tree=Try&rev=39cacaff246b
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
Flags: needinfo?(cpeterson)
And then I fixed the Linux compile errors by adding an include guard to nsGNOMERegistry.h:

https://tbpl.mozilla.org/?tree=Try&rev=bf27ee7a666a
Attachment #8339690 - Attachment is obsolete: true
Attachment #8339757 - Flags: review?(ehsan)
Attachment #8339757 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/d4c8a4014d61
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.