940255 - [Australis] Cut/Copy/Paste text not in the middle of the buttons

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

It looks a bit unpolished when cut/copy/paste texts aren't in the middle of the buttons,
especially when comparing copy to the 100% button (which btw doesn't seem to do anything, yet behaves like a button) beneath it.

Comment 1

[Matthew N. [:MattN]]

Is it vertical or horizontal alignment that's the issue? Can you attach a screenshot?

The 100% button resets to the default zoom level, perhaps it should be disabled when it's at the default zoom level (100%). I filed this as bug 940267.

Comment 2

[:Gijs (he/him)]

(In reply to Matthew N. [:MattN] (catching up on reviews) from comment #1)
> Is it vertical or horizontal alignment that's the issue? Can you attach a
> screenshot?
> 
> The 100% button resets to the default zoom level, perhaps it should be
> disabled when it's at the default zoom level (100%). I filed this as bug
> 940267.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: cut_copy_paste.png

Comment 4

[Mike de Boer [:mikedeboer]]

This'll be fixed with bug 878065.

Comment 5

[Mike de Boer [:mikedeboer]]

bug 878065 fixed, but it still needs a bit more tweaking.

Comment 6

[Justin Dolske [:Dolske]]

Attachment: Strange spacing

Hmm. I took at look at this before I saw that bug 878065 was supposed to fix it, but then noticed I'm on the current (11/22) Nightly -- which should have that fix but still is a bit off.

I see two general nits:

* The left and right padding in the panel seems different (cyan box). 15 on the left, 12 on the right.

* Where should the labels go?

  I think we're currently centering the label in whitespace to the right of the icon, but that's still a bit off (pink/blue boxes). Probably because there's other padding/margin at the end? (EG instead of "[icon]----text----" it's "[icon]----text----___", and so the text is offset a bit to the left.

  But I think what smaug is asking for is that the text be centered in the region, ignoring the space consumed by the icon. The labels would appear closer to the icon, but align with the contents of the zoom control underneath.

Not sure which way is "correct", but we're not doing either quite right. :)

Comment 7

[Justin Dolske [:Dolske]]

Attachment: Centered mock

I think this is smaug's suggestion.

Comment 8

[Justin Dolske [:Dolske]]

A 3rd form is in shorlander's mockup, which centers the combination of the icon+label:

http://people.mozilla.org/~shorlander/customizationMode-liveDemo-i02/windows7-customizationMode-i02.html

I think either fixing the current alignment or going with that mockup makes sense. Having the label centered happens to align with the zoom controls, but otherwise looks off-balance to me. Steven, what do you want? :)

Comment 9

[Stephen Horlander [:shorlander]]

(In reply to Justin Dolske [:Dolske] from comment #8)
> A 3rd form is in shorlander's mockup, which centers the combination of the
> icon+label:
> 
> http://people.mozilla.org/~shorlander/customizationMode-liveDemo-i02/
> windows7-customizationMode-i02.html
> 
> I think either fixing the current alignment or going with that mockup makes
> sense. Having the label centered happens to align with the zoom controls,
> but otherwise looks off-balance to me. Steven, what do you want? :)

The icon+label is a grouped item that should be vertically centered in the container.

Comment 10

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Justin Dolske [:Dolske] from comment #7)
> Created attachment 8337154 [details]
> Centered mock
> 
> I think this is smaug's suggestion.

That one won't work in locales with longer words, unfortunately.
In German for example, »Cut« is »Ausschneiden« and that's not going to look centered anymore.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.